Skip to content

Fix NaN handling in ttftBucketIndex #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NaN handling in ttftBucketIndex #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common/src/util/ttft-histogram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ const LN_BASE = Math.log(TTFT_HISTOGRAM_BASE)
* Sub-millisecond and zero samples land in bucket 0 rather than at -Infinity.
*/
export function ttftBucketIndex(ttftMs: number): number {
const index = Math.floor(Math.log(Math.max(ttftMs, 1)) / LN_BASE)
const safeTtftMs = Number.isFinite(ttftMs) ? ttftMs : 0
const index = Math.floor(Math.log(Math.max(safeTtftMs, 1)) / LN_BASE)
return Math.min(TTFT_HISTOGRAM_BUCKET_COUNT - 1, Math.max(0, index))
}

Expand Down
Loading