Skip to content

Use Number.isNaN instead of global isNaN in dates utility #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Number.isNaN instead of global isNaN in dates utility #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/util/dates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const formatTimeUntil = (
const target = typeof date === 'string' ? new Date(date) : date
const diffMs = target.getTime() - Date.now()

if (isNaN(diffMs) || diffMs <= 0) return fallback
if (Number.isNaN(diffMs) || diffMs <= 0) return fallback

const diffMins = Math.floor(diffMs / (1000 * 60))
const diffHours = Math.floor(diffMins / 60)
Expand Down
Loading