Use Number.isNaN instead of global isNaN in saxy XML parser - #1235
Open
pavankumar-vh wants to merge 1 commit into
Open
Use Number.isNaN instead of global isNaN in saxy XML parser#1235pavankumar-vh wants to merge 1 commit into
pavankumar-vh wants to merge 1 commit into
Conversation
The global isNaN() function coerces non-numbers to numbers first, which can lead to unexpected results. Using Number.isNaN is more predictable and safer for type checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix type safety issue in
common/src/util/saxy.tsby usingNumber.isNaNinstead of the globalisNaNfunction.Bug Description
The global
isNaN()function coerces non-numbers to numbers first, which can lead to unexpected results.Fix
Changed
isNaN(value)toNumber.isNaN(value)for more predictable and safer type checking.Testing
No existing tests for this function, but the fix improves type safety.
Files Changed
common/src/util/saxy.ts- Use Number.isNaN instead of global isNaNScope
This change only touches
common/which is an approved contribution area per the Contributing Guide.