You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recreated on the rewritten main after #1102 was auto-closed during repository maintenance. This carries the same reviewed change set on the new history.
Summary
disable the animated chat-header logo sheen in Freebuff builds
keep the existing animation for standard Codebuff builds
add focused regression coverage for both product paths
Clean, minimal change. IS_FREEBUFF was already imported and used in chat-header.tsx, so gating the sheen animation on it follows existing convention rather than introducing new branching logic. The extraction into shouldAnimateChatHeader as a pure function is a nice touch — easy to unit test in isolation (chat-header-animation.test.ts), and the three cases (Freebuff+enabled, Codebuff+enabled, disabled for both) cover the meaningful branches.
A couple of minor points a maintainer will likely want addressed before porting:
No visual/manual confirmation mentioned beyond the unit tests — since this is a rendering/animation change, it'd help to note that the static logo still renders correctly in Freebuff builds (colors, block layout unaffected), not just that the boolean flips.
Addressed both follow-ups. The helper docstring is now behavioral rather than asserting an unverified post-rewrite flicker cause. I also rechecked the rendering diff: the only chat-header.tsx behavior change is the enabled argument passed to the sheen hook; logoColor, accentColor, blockColor, and the header layout/rendering path are untouched. The focused animation tests pass 3/3, covering Freebuff static, Codebuff animated, and globally-disabled cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1035
Validation
Prior validation before the history rewrite:
tarandreact-dom/serverdeclarations; no errors from changed filesgit diff --check: passed