Skip to content

fix(cli): disable Freebuff chat logo sheen - #1184

Open
c8dhjp4tyv-bit wants to merge 2 commits into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1102-freebuff-chat-logo-sheen
Open

fix(cli): disable Freebuff chat logo sheen#1184
c8dhjp4tyv-bit wants to merge 2 commits into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1102-freebuff-chat-logo-sheen

Conversation

@c8dhjp4tyv-bit

Copy link
Copy Markdown

Recreated on the rewritten main after #1102 was auto-closed during repository maintenance. This carries the same reviewed change set on the new history.

Summary

  • disable the animated chat-header logo sheen in Freebuff builds
  • keep the existing animation for standard Codebuff builds
  • add focused regression coverage for both product paths

Fixes #1035

Validation

Prior validation before the history rewrite:

  • focused animation tests: 3 passed
  • related queue tests: 4 passed
  • full CLI suite: 2,367 passed, 9 skipped; existing checkout/environment failures remain (34 failed tests and 32 harness errors)
  • CLI typecheck: existing missing tar and react-dom/server declarations; no errors from changed files
  • Prettier check for changed files: passed
  • git diff --check: passed

@codebuff-team

Copy link
Copy Markdown
Contributor

Clean, minimal change. IS_FREEBUFF was already imported and used in chat-header.tsx, so gating the sheen animation on it follows existing convention rather than introducing new branching logic. The extraction into shouldAnimateChatHeader as a pure function is a nice touch — easy to unit test in isolation (chat-header-animation.test.ts), and the three cases (Freebuff+enabled, Codebuff+enabled, disabled for both) cover the meaningful branches.

A couple of minor points a maintainer will likely want addressed before porting:

Otherwise this is exactly the kind of small, targeted, testable fix that's easy to port by hand. Good work.

@codebuff-team codebuff-team added bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree labels Sep 1, 2026

Copy link
Copy Markdown
Author

Addressed both follow-ups. The helper docstring is now behavioral rather than asserting an unverified post-rewrite flicker cause. I also rechecked the rendering diff: the only chat-header.tsx behavior change is the enabled argument passed to the sheen hook; logoColor, accentColor, blockColor, and the header layout/rendering path are untouched. The focused animation tests pass 3/3, covering Freebuff static, Codebuff animated, and globally-disabled cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can the FREEBUFF flashing effect displayed by CLI be turned off? It is currently causing the input method to flicker

2 participants