fix(sdk): take max of OpenRouter cost and upstream_inference_cost - #1165
Closed
nordicnode wants to merge 9049 commits into
Closed
fix(sdk): take max of OpenRouter cost and upstream_inference_cost#1165nordicnode wants to merge 9049 commits into
nordicnode wants to merge 9049 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usage.cost + cost_details.upstream_inference_costat all three cost sites (sdk/src/impl/llm.tsstreamingreportCost,generateText, and structured paths)usage.costis the total amount charged and already includes the upstream portion reported separately incost_details, per OpenRouter's usage accounting docs — summing them roughly doubles credits on normal (non-BYOK) OpenRouter routes, which lines up with the "extreme inflation" reports on Discordcommon/src/constants/freebuff-models.ts:313-320: cost = 0 there and upstream carries the real spend, so max is correct for both shapes)cost=0.01, upstream=0.02(fails under the sum: 3 vs 2)Fixes #1164
Validation
bun test sdk/src/impl/__tests__/usage-receipts.test.ts(5 pass, 1 new — verified the new test fails with the sum by stashing the fix)bun test sdk(489 pass; the 100 failures are network/env-dependent and pre-exist onmain)bunx tsc --noEmit -p sdk/tsconfig.jsonclean