chore(release): 0.12.1 - #596
Merged
Merged
Conversation
Bumps keel-trader and the seven workspace packages from 0.12.0 to 0.12.1, plus every '==' sibling pin and uv.lock. A patch, not a minor: one user-facing change since v0.12.0 -- the browser UI wears keeltrading.com's identity (#594: the palette, the mark on every icon, the hull that closes and the caps that land) -- plus #592's release-workflow fix (the Windows attestation subjects are newline-separated, not space-separated), which ships no runtime code. All eight distributions move as one set; tests/test_packaging.py pins the sibling '==' constraints, which is how this bump caught itself half-finished on the first red run. uv.lock moves with them (8 lines: one version per distribution, nothing else) -- the release workflow checks it is current before anything else.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The version-bump PR for 0.12.1, following #591's precedent exactly: one commit, every version and every
==pin moves together,uv.lockmoves with them. Perdocs/RELEASING.md, merging this (not the workflow) is what sets the version — the release workflow then refuses to change it.Patch, not a minor: since
v0.12.0the only user-facing change is #594, and #592 ships no runtime code. No new interfaces, so the patch is right.What ships in 0.12.1
Enumerated from
git log --oneline v0.12.0..HEAD:Files bumped
pyproject.toml—version0.12.0 → 0.12.1, plus the three sibling pins (keel-core,keel-broker-api,keel-broker-coinbase)packages/{keel-core,keel-broker-api,keel-broker-coinbase,keel-broker-alpaca,keel-broker-fake,keel-broker-robinhood,keel-broker-kraken}/pyproject.toml— eachversion, plus the 11 inter-package==pinsuv.lock— regenerated withuv lock; diff is exactly 8 lines (one version per distribution), no unrelated churn;uv lock --checkpasses9 files, 25 insertions, 25 deletions. Nothing else: a repo-wide grep for
0.12.0finds only inert prose — the exampleISCC.exe /DKeelVersion=0.12.0invocation comment inpackaging/keel.iss(the real value is passed as a define by the workflow; the#ifndefdefault is0.0.0), and the two comments narrating the historical v0.12.0 attestation dispatch failure intests/test_desktop_packaging.pyand.github/workflows/release.yml. No live pins or expectations left behind.Lock discipline
The trap from #422/#482, verified TDD-style: bumping only the root
pyproject.toml'sversionfirst madetests/test_packaging.pyfail exactly as designed —After completing the set (all 8 pyprojects, 14 pins,
uv lock), the same suite is green.uv.lockrides in the same commit because the release workflow checks it is current before anything else (#424).Gates
uv run pytest tests/test_packaging.py -q— 22 passeduv run pytest -q— 4422 passed, 3 skippeduv run ruff check .— all checks passeduv run mypy— no issues in 350 source filesDo not merge unreviewed: the release workflow runs next, after merge, with this same version.