docs(setup): a refused promotion is the gate working, and the checklist should say so - #471
Merged
Merged
Conversation
…st should say so
Measured on a real deployment while verifying D4's acceptance. A freshly-seeded turtle_breakout,
promoted from the browser against 74,714 real candles, was refused:
n_trades 12 < min_trades 100
win_rate 0.5 < min_win_rate 0.55
overfitting check (G4 / PBO-CSCV) NOT RUN: no trial matrix was supplied, so the probability
that this rule's parameters were selected by overfitting is UNKNOWN -- which is not the same
as low, and is not a pass.
status -> candidate
That is exactly right, and it is also the single most likely thing a first-run user will see on
this step. Left unexplained it reads as a broken button on a checklist that has gone green
everywhere else -- so the step now says a refusal is the gate doing its job, that this item can
stay outstanding for a long time, and that the deliberate bypass is `keel rules promote --force`
at a terminal, on the record.
`ready_for(PAPER)`'s docstring gains the same correction. "Set up" and "has a rule worth running"
are different states; it reports the second, and a fresh install does not reach it quickly.
No behaviour changes. The website already says this about `keel simulate` -- "it will very likely
tell you TRAIN MORE and name the gates that fail; that is the engine working, not broken; the
honesty is the feature" -- and the setup checklist was the one surface still missing it.
4094 passed, 3 skipped (2 new). ruff clean repo-wide.
Refs #437, #18.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #437 (D4). No behaviour change — wording plus two pins.
Found while verifying D4's acceptance end to end on a real deployment.
What happened
A freshly-seeded
turtle_breakout, promoted from the browser against 74,714 real candles:That is exactly right. It is also the single most likely thing a first-run user will see on this step — and left unexplained it reads as a broken button on a checklist that has gone green everywhere else.
What changed
The step now says a refusal is the gate doing its job, that this item can stay outstanding for a long time, and that the deliberate bypass is
keel rules promote --force— at a terminal, on the record.ready_for(PAPER)'s docstring gains the same correction: "set up" and "has a rule worth running" are different states. It reports the second, and a fresh install does not reach it quickly.The website already says this about
keel simulate— "it will very likely tell you TRAIN MORE and name the gates that fail — that is the engine working, not broken; the honesty is the feature" — and the setup checklist was the one surface still missing it.4094 passed, 3 skipped (2 new).
ruff checkclean repo-wide.The open question this surfaces
D4's acceptance reads "a user with no prior state reaches a working paper deployment without typing a command." Every mechanical and operator-input step now gets there.
rule_promoteddoes not, and cannot, because a fresh rule legitimately fails the gate.Two ways to close that, and I would not pick the first:
--forcein the browser. No — it is one of the eleven, andattempt_promotionstates that force carries no gate at the service level, so the front-end is the gate. A browser cannot keep that contract.🤖 Generated with Claude Code