fix(broker-alpaca): NaN-safe money coercion, host-map-only construction, quoted path segments - #384
Merged
Merged
Conversation
…on, quoted path segments
Adversarial-review findings on the new keel-broker-alpaca package:
1. _decimal_or_none now rejects non-finite Decimals explicitly: JSON NaN/Infinity
tokens arrive via parse_constant (not parse_float) and Decimal(str(...)) parses
them without raising, so the except never fired -- NaN crashed preview_order
(bid > 0) and get_balances (min()), Infinity compared as a real price, and NaN
silently poisoned Candle OHLCV. Non-finite now lands in the same None path as
any unparseable leaf, keeping the preview's errors invariant true.
2. Removed the dead trading_host=/data_host= constructor escapes (zero callers):
TRADING_HOSTS is now the only map from an environment choice to a host, making
the README's no-paper-to-live-path claim literally true of the signature.
3. Percent-encode interpolated path segments (quote(..., safe='')) at every site:
/v2/orders/{id} on GET/DELETE and /v2/stocks/{symbol}/bars|quotes/latest, so a
'/' or '?' inside an id or symbol can never reshape the request.
4. to_unix_seconds refuses offset-less timestamps (ValueError) instead of letting
.timestamp() silently assume the host's local zone.
5. Reworded the SEC Section 31 provenance: advisory 2026-2 (.60/M) is already
in force (2026-04-04), Alpaca's page is the stale side, and the encoded .90
deliberately tracks the venue's own figure (~/bin/zsh.02/k, conservative) with the
delta as the re-measurement trigger.
All tests written red-first; gates: 3110 passed/1 skipped, ruff clean, mypy clean.
This was referenced Aug 19, 2026
Merged
eaitbrahim
added a commit
that referenced
this pull request
Aug 20, 2026
Minor, not patch. Three things since v0.9.3 change what an implementor or a deployment can rely on: * A NEW DISTRIBUTION. `keel-broker-alpaca` (#382, #384) plus the paper-equities profile that selects it (#386), so a deployment can now be US equities via the broker port rather than crypto only. * THE PORT CONTRACT MOVED TWICE. `market_clock`/`market_schedule` made venues session-aware (#385), and `place_order` gained `idempotency_key` (#419). Both carry defaults so no CALLER breaks, but a third-party adapter that does not accept them is no longer a `Broker` -- the conformance suite now says so. That is exactly the kind of change a patch bump must not hide. * THE OPERATOR CONSOLE. The TUI became keel's console across #399-#408, and `keel update` (#415/#417) makes a deployment self-updating. Every pinned sibling moves with it. The four production distributions are required `==` at this exact version (`RELEASING.md`, "Release assets"), so a bump that missed one would install a mixed set -- the `keel-trader 0.5.7` against `keel-core 0.5.5` failure `keel versions` exists to catch, and which `~/keel` actually ran across two releases. Also in this window, on the Robinhood adapter: the best_bid_ask fixture corrected against the live venue (#414), a credential guard that catches the error it only claimed to (#416), pre-flight sizing reported on the preview (#418), transport backoff (#420), and the fenced one-order probe (#421). Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #382 (merged pre-review): the adversarial review's five findings, applied TDD red-first.
_decimal_or_noneparsed'nan'/'Infinity'successfully (JSONNaNarrives viaparse_constant), crashingpreview_orderatbid > 0andquote_size / crossed,get_balancesatmin(buying_power, cash), and silently poisoning Candle OHLCV — contradicting the preview docstring's populate-errorsinvariant. Nowis_finite()-guarded; three red-first tests cover quote sides, balances, and bar leaves.trading_host=/data_host=overrides (zero callers anywhere) are REMOVED;TRADING_HOSTSis the only endpoint→host map and the README's "no configuration path from a paper credential to the live host, by construction" is now literally true (pinned by test).safe="") at all four sites;A/B-USDand a crafted order id can no longer reshape the request (asserted on the outgoing URL).ValueErrorper the module's refusal convention.Gates:
uv run pytest -q→ 3110 passed, 1 skipped; ruff clean; mypy clean (249 files).Refs #369 (Phase A hardening).