chore: require Python 3.14.4; move ruff config to ruff.toml - #122
Merged
Conversation
Bump the floor from >=3.12 to >=3.14.4 across the root project and all four workspace members, so no member is left with a laxer floor than the workspace resolves against. Ruff config moves out of [tool.ruff] into a root ruff.toml. A ruff.toml takes precedence over [tool.ruff], so keeping both would leave the pyproject copy silently dead; it is deleted rather than duplicated. target-version follows to py314, as does mypy's python_version. .python-version and uv.lock both had 3.12 baked in and contradicted the new floor -- uv refuses to sync in that state -- so both are regenerated. No source changes were needed: 1322 tests, ruff, and mypy all pass on 3.14.4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… pinned interpreter
The release workflow's artifact-verification step built its venv with the
runner's default `python` (3.12 on ubuntu-24.04) and then pip-installed the
freshly built wheel into it. With the floor raised, that wheel carries
`Requires-Python: >=3.14.4`, which pip enforces even for an explicit local
wheel path:
ERROR: Package 'keel-trader' requires a different Python: 3.12.12 not in '>=3.14.4'
Reproduced locally against a real `uv build` artifact. It would have aborted
the release after the build, and no local check could have caught it. The venv
is now created with `uv venv --seed --python "$(cat .python-version)"`; --seed
supplies the pip the install step needs. Installing by explicit path, which is
the point of the step, is unchanged.
The three `uv python install 3.12` lines are now argument-less so the version
is read from .python-version. Pinning the same version in four files is what
let this drift in the first place; migrate.yml anticipates self-hosted runners,
where the silent 3.14 re-download that currently masks the staleness would not
save us.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the Python floor from
>=3.12to>=3.14.4and moves ruff's config out ofpyproject.tomlinto a rootruff.toml.What changed
requires-python→>=3.14.4in the root project and all four workspace members. Leaving a member at>=3.12would give it a laxer floor than the workspace actually resolves against.ruff.toml(new) holdsline-length,target-version = "py314", and theE,F,I,UP/ignore = ["UP042"]lint config. The[tool.ruff]block inpyproject.tomlis deleted, not duplicated — aruff.tomltakes precedence over[tool.ruff], so keeping both would leave the pyproject copy silently dead.[tool.mypy] python_version→"3.14"to match..python-versionanduv.lockboth had 3.12 baked in and contradicted the new floor (uv refuses to sync in that state), so both are regenerated.Notes for review
No source changes were needed — this is config only.
The
uv.lockdiff looks large but contains no version changes. 66 of its 137 removed lines arecp312wheel URLs that are unreachable under the higher floor; the rest is the same pruning for other dropped interpreter tags. Every package version is byte-identical before and after.Verification on 3.14.4
coinbase-advanced-pyandcryptography==49.0.0both ship 3.14 wheels, so nothing builds from source.🤖 Generated with Claude Code