Skip to content

Make Electron CI fail on incomplete bundles and missing DMGs - #225

Merged
Sma1lboy merged 2 commits into
mainfrom
fix/build-verification-20261001
Oct 1, 2026
Merged

Sma1lboy merged 2 commits into
mainfrom
fix/build-verification-20261001

Conversation

@Sma1lboy

@Sma1lboy Sma1lboy commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Independent CI-integrity fix found during #224 verification. No app or website behavior changes.

Before → after

Build Check run 36857249679 reported success despite two FATAL ERROR / JavaScript heap-out-of-memory crashes. Forge did not reliably propagate the Vite subprocess failure.

  • Bounded 4 GiB Node heap, also proven by the real Electron workflow in Clarify provider setup, refresh failures and memory processing #224
  • Strict pipeline exit codes plus explicit fatal/OOM log rejection
  • Require nonempty main/preload/renderer entries and packaged Convera.app
  • Make from that verified package (--skip-package), then require a nonempty DMG
  • Retain build logs on success or failure

Tests

Limits

No release signing, publishing, deployment, merging or production changes. This strengthens PR build verification; it does not assert that all other CI checks or full type-checks are clean.

See docs/ux-build-verification.md for the reproduced failure and acceptance conditions.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
foxyfox-docs Error Error Oct 1, 2026 11:57am UTC
foxyfox-website Ready Ready Preview Oct 1, 2026 11:57am UTC

Request Review

@Sma1lboy
Sma1lboy marked this pull request as ready for review October 1, 2026 20:11
@Sma1lboy
Sma1lboy merged commit 5f21c9a into main Oct 1, 2026
4 of 5 checks passed

This branch had an error being deployed

1 failed and 1 active deployments
Preview – foxyfox-website — 0b39ca6b Deployed Oct 1, 2026 by vercel[bot]
Preview – foxyfox-docs — 0b39ca6b Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant