Repository navigation
Make Electron CI fail on incomplete bundles and missing DMGs - #225
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent CI-integrity fix found during #224 verification. No app or website behavior changes.
Before → after
Build Check run 36857249679 reported success despite two
FATAL ERROR/ JavaScript heap-out-of-memory crashes. Forge did not reliably propagate the Vite subprocess failure.--skip-package), then require a nonempty DMGTests
git diff --checkpassed0b39ca6b3d99f88f6a2c1c0880ae71066728ebd9: strict macOS package and DMG verification passed, Linux unit tests passedLimits
No release signing, publishing, deployment, merging or production changes. This strengthens PR build verification; it does not assert that all other CI checks or full type-checks are clean.
See docs/ux-build-verification.md for the reproduced failure and acceptance conditions.