Ci/always run all tests#110
Merged
Merged
Conversation
chrisdedman
approved these changes
Jul 5, 2026
chrisdedman
left a comment
chrisdedman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This will improve our coverage by a lot and make sure we never fail behind. Thanks
Contributor
|
@PenguinBoi12 can you fix the CI before merging. thanks |
Contributor
Author
Ofc, just haven't had time to fully fix it. Will push a fix tonight. Can't merge without fixing it anyway |
PenguinBoi12
force-pushed
the
ci/always-run-all-tests
branch
from
23205d6 to
9b71435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
continue-on-error: true, so a failure in one no longer skips the others. This will improve visibility in the CI (ex. if both formatting and tests fails we can see it)pytest-covand set--cov-fail-under=90on thepyteststep, so the build fails if test coverage drops below 90%. This is to ensure we don't forget too many tests and keep our coverage high.Type of Change
Pre-merge Checklist
pytestmypy