314 add internal admin notes field to application records#332
Open
cheangie wants to merge 2 commits into
Open
Conversation
…DTO, service, controller, and tests
7 tasks
SamNie2027
requested changes
Jun 18, 2026
| `ALTER TABLE "application" DROP CONSTRAINT "CHK_application_desiredExperience_allowed"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `ALTER TABLE "application" ADD "internalNotes" character varying`, |
Collaborator
There was a problem hiding this comment.
Remove everything else from this migration but this query please - we only want to put in the migration what is relevant to the goal you are trying to achieve
| `ALTER TABLE "discipline" DROP CONSTRAINT "UQ_8e7dbc4c94e2523e93a8204c9c9"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `ALTER TABLE "application" DROP COLUMN "internalNotes"`, |
Collaborator
There was a problem hiding this comment.
Same comment as above but just specifically for the down one ^
| relationship={application.emergencyContactRelationship} | ||
| /> | ||
|
|
||
| <Box borderWidth="1px" borderRadius="lg" p={6} bg="orange.50"> |
Collaborator
There was a problem hiding this comment.
Keep in mind that our designers used every other white/grey coloring on the application view in purpose - so please keep the admin view in line with that and just implement every other white/grey coloring rather than this yellow color.
| <Heading as="h2" size="md" mb={1}> | ||
| Internal Notes | ||
| </Heading> | ||
| <Text fontSize="sm" color="orange.700" mb={3}> |
Collaborator
There was a problem hiding this comment.
I do think this text being this color is good though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes <#314>
📝 Description
Added an internal notes field to application records that is only visible to admins.
Briefly list the changes made to the code:
✔️ Verification
Ran and tested locally using the superadmin login. Added notes, saved them, refreshed page, left page, and ensure they saved. Logged in using the standard login, and ensured that the internal notes column wasn't visible for a standard user.
Screen.Recording.2026-06-16.at.9.59.45.PM.mov