Skip to content

Properly try/except and fix tests#212

Merged
CoMPaTech merged 2 commits into
mainfrom
testfix
May 21, 2026
Merged

Properly try/except and fix tests#212
CoMPaTech merged 2 commits into
mainfrom
testfix

Conversation

@CoMPaTech
Copy link
Copy Markdown
Owner

No description provided.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@CoMPaTech has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 26 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e44221c4-a50c-421f-b970-cea15abaf0db

📥 Commits

Reviewing files that changed from the base of the PR and between 2d85339 and 1008776.

📒 Files selected for processing (1)
  • airos/airos6.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch testfix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (be6e626) to head (1008776).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   86.66%   86.77%   +0.10%     
==========================================
  Files           8        8              
  Lines         750      756       +6     
==========================================
+ Hits          650      656       +6     
  Misses        100      100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AirOS6 client to handle network-level failures during v6 login more consistently with the rest of the library.

Changes:

  • Switches to importing aiohttp directly and updates the ClientSession type annotation accordingly.
  • Wraps _login_v6() in AirOS6.login() with a try/except to convert TimeoutError / aiohttp.ClientError into AirOSDeviceConnectionError.
Comments suppressed due to low confidence (1)

airos/airos6.py:29

  • The __init__ docstring says "Initialize AirOS8 class." but this is AirOS6. Please correct the docstring to avoid misleading documentation and keep it consistent with the class.
        session: aiohttp.ClientSession,
        use_ssl: bool = True,
    ) -> None:
        """Initialize AirOS8 class."""
        super().__init__(

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread airos/airos6.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@CoMPaTech CoMPaTech merged commit e4ed21a into main May 21, 2026
12 checks passed
@CoMPaTech CoMPaTech deleted the testfix branch May 21, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants