Repository navigation
Run publishing when a release goes live - #251
Merged
Merged
Conversation
GitHub does not trigger the created activity for draft releases. Listen for published so both immediate releases and drafts promoted through the UI start the binary and container publishing jobs. Grant the release asset upload job contents: write explicitly. It currently inherits that access from repository settings, but needs it to attach binaries and checksums to the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run binary and container publishing on
release.published. GitHub doesnot trigger
release.createdfor draft releases, so publishing a draftthrough the UI currently leaves the release without assets or images.
Give the binary upload job
contents: writeexplicitly, which it needsto attach the six binaries and their checksums. The repository currently
grants this permission by default, but the job should not depend on that
setting.
Validation
publishing jobs' permissions.
and arm64 with artifacts from the successful PR Publish CloudInvoke images to two registries #250 CI run.
matrix and to its job dependencies.
A PR run cannot execute a release-only job. The first published unFTP
release will exercise registry authentication and asset uploads.