Repository navigation
Conversation
The HELP reply names the library and its exact version to any client, and nothing could change it. ServerBuilder::help_text sets the lines of the 214 reply instead; without it, the reply is unchanged. Closes Cloudinvoke#608
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #608.
The
HELPreply names the library and its exact version to any client, and there was no way to change it. This addsServerBuilder::help_text, next togreeting(), to set the lines of the214reply:HELPhandler the same way as the greeting (Server→OptionsHolder→ control loop config →PrimaryEventHandler), shared through anArc<[String]>.tests/help.rschecks both the default reply and a custom one, over a real control connection.CHANGELOG.md: an entry under a new "Unreleased" section.Checked locally.