Bring in focused upstream UI and UX improvements - #25
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b461f6770
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await database | ||
| .delete(skillTools) | ||
| .where(eq(skillTools.skillId, input.slug)); | ||
| if (declared.length > 0) { | ||
| await database.insert(skillTools).values( |
There was a problem hiding this comment.
When two clients save the same skill concurrently—for example, an admin tab and the personal skill editor—the separate delete and insert operations can interleave: disjoint saves leave a union of both tool lists, while overlapping saves can hit the composite primary key and return an error after the skill text was already updated. Run the skill upsert and declaration replacement in one transaction so each save produces one consistent last-writer-wins state.
Useful? React with 👍 / 👎.
| <CopilotChat | ||
| agentId={agentId} | ||
| chatView={BotChatView} | ||
| key={agentId} | ||
| key={`${agentId}:${threadId}`} | ||
| messageView={{ cursor: BotThinkingCursor }} | ||
| threadId={threadId} |
There was a problem hiding this comment.
When the previous conversation ended with a run error, starting a new chat remounts only CopilotChat; useStoppedTurn(agentId) remains mounted and retains the prior thread's error until the first run in the new thread begins. Consequently, the new empty conversation initially displays an alert describing a failure that occurred in a different conversation, so the stopped state should be cleared or keyed by threadId when the new thread is selected.
Useful? React with 👍 / 👎.
1 participant
What this adds
Safety
Database
skill_toolsthrough migration0012_dusty_wraith.sqland its reviewed Drizzle snapshotValidation