Drop Carthage support and adopt Swift Package Manager layout#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ends the legacy Carthage-oriented repository layout and makes Swift Package Manager the primary project structure.
Lib/KeyHoldertoSources/KeyHolderand tests fromLib/KeyHolderTeststoTests/KeyHolderTests.Package.swiftto use the standard SwiftPM source and test target paths, and declare the direct Sauce dependency used byRecordView.KeyHolderSwift package product directly and resolve Magnet/Sauce through SwiftPM.This keeps the package focused on SwiftPM as the source of truth while preserving the Example app as a consumer of the local package.
Checked locally with
swift testandxcodebuild -project Example/Example.xcodeproj -scheme Example -configuration Debug -derivedDataPath /private/tmp/KeyHolderDerivedDataReview CODE_SIGNING_ALLOWED=NO build.