Skip to content

Drop Carthage support and adopt Swift Package Manager layout#88

Merged
Econa77 merged 2 commits into
masterfrom
drop-carthage-support
Jun 19, 2026
Merged

Drop Carthage support and adopt Swift Package Manager layout#88
Econa77 merged 2 commits into
masterfrom
drop-carthage-support

Conversation

@Econa77

@Econa77 Econa77 commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

This ends the legacy Carthage-oriented repository layout and makes Swift Package Manager the primary project structure.

  • Move the library sources from Lib/KeyHolder to Sources/KeyHolder and tests from Lib/KeyHolderTests to Tests/KeyHolderTests.
  • Remove the old library Xcode project, workspace, Carthage files, and Magnet/Sauce submodules that were only needed for the previous framework-based setup.
  • Simplify Package.swift to use the standard SwiftPM source and test target paths, and declare the direct Sauce dependency used by RecordView.
  • Update the Example app to link the local KeyHolder Swift package product directly and resolve Magnet/Sauce through SwiftPM.
  • Replace the README CI badge with the existing SwiftPM build workflow and drop the unused CocoaPods gem dependency.

This keeps the package focused on SwiftPM as the source of truth while preserving the Example app as a consumer of the local package.

Checked locally with swift test and xcodebuild -project Example/Example.xcodeproj -scheme Example -configuration Debug -derivedDataPath /private/tmp/KeyHolderDerivedDataReview CODE_SIGNING_ALLOWED=NO build.

@Econa77 Econa77 marked this pull request as ready for review June 19, 2026 02:08
@Econa77 Econa77 merged commit 7f17897 into master Jun 19, 2026
8 checks passed
@Econa77 Econa77 deleted the drop-carthage-support branch June 19, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant