Windows installer hardening: local ARP uninstall, native download/hash, strict registration success - #6
Merged
Conversation
…utton labels for clarity
- Removed custom extension ID usage from README. - Updated Windows uninstall instructions to recommend using Apps and Features. - Added support for silent uninstall via command line in the installer. - Introduced CLI options parsing for uninstall functionality. - Enhanced error handling and user feedback during uninstall process. - Replaced PowerShell commands with Rust-based implementations for downloading files and verifying checksums. - Improved registration of native messaging hosts for multiple browsers. - Added SHA256 checksum verification for downloaded binaries. - Updated Cargo.toml to include new dependencies for HTTP requests and hashing.
- switch ARP uninstall to local setup command using silent uninstall mode - add CLI uninstall and silent flags for setup binary - replace runtime PowerShell download/hash operations with native Rust HTTP + SHA256 - fail install when browser host registration succeeds for zero supported browsers - update installer plan with hardening steps and implementation status
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens Windows installer behavior by removing remote-script uninstall from Apps & Features, adding deterministic setup uninstall flags, replacing runtime PowerShell download/hash operations with native Rust logic, and preventing false-positive installs when no browser registration succeeds.
Changes
Validation