Description
When a YouTube Music ad plays, the presence shows the ad's title/artist instead of clearing. The isAdPlaying() DOM check added in 6255030 is not reliably catching ads in the browser extension context (as opposed to a desktop app), likely because the ad attribute/elements are not yet present in the DOM at the time UpdateData fires.
Steps to reproduce
- Open YouTube Music (free tier / no Premium)
- Wait for an instream audio ad to play
- Observe Discord Rich Presence — shows ad content instead of clearing
Expected behaviour
Presence clears (no activity shown) for the duration of the ad.
Possible causes
ytmusic-player-bar[has-ad] attribute may not be set at ad start; needs verification in a live browser sessionytmusic-ad-instream-companion-slot may not be present for audio-only adsUpdateData interval may fire before the ad DOM signals appear
Suggested investigation
Inject a console log in isAdPlaying() to confirm which (if any) selector matches during an ad. May need to add video.src or mediaSession.metadata.artwork heuristics as a fallback (ads often have no artwork or a placeholder src).
Description
When a YouTube Music ad plays, the presence shows the ad's title/artist instead of clearing. The
isAdPlaying()DOM check added in 6255030 is not reliably catching ads in the browser extension context (as opposed to a desktop app), likely because the ad attribute/elements are not yet present in the DOM at the timeUpdateDatafires.Steps to reproduce
Expected behaviour
Presence clears (no activity shown) for the duration of the ad.
Possible causes
ytmusic-player-bar[has-ad]attribute may not be set at ad start; needs verification in a live browser sessionytmusic-ad-instream-companion-slotmay not be present for audio-only adsUpdateDatainterval may fire before the ad DOM signals appearSuggested investigation
Inject a console log in
isAdPlaying()to confirm which (if any) selector matches during an ad. May need to addvideo.srcormediaSession.metadata.artworkheuristics as a fallback (ads often have no artwork or a placeholder src).