Preserve precision for numeric power functions - #339
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
marked this pull request as draft
August 3, 2026 23:56
fallintoplace
marked this pull request as ready for review
August 3, 2026 23:58
theory
requested changes
Aug 6, 2026
theory
left a comment
Collaborator
There was a problem hiding this comment.
ClickHouse pow() takes a Decimal value, so we should be able to evaluate numerics without loss of precision.
Collaborator
|
Oh I see, it returns Float64. I don't know whether this loss of precision matters, though. |
Contributor
Author
|
Yes, it matters for exact comparisons. In ClickHouse 26.7, pow(Decimal128(...), 2) accepts Decimal input but returns Float64, producing 1.5241578753238834 instead of PostgreSQL’s exact numeric result 1.524157875323883675. The regression demonstrates that pushing it down changes the result, so numeric pow()/power() should remain local while float8 remains pushed down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse evaluates
pow()as Float64, so pushing down PostgreSQLnumericoverloads can round values before an exact comparison. Keepfloat8pushdown, but evaluate numericpow()andpower()locally in PostgreSQL.The regression uses a Decimal128 source value to cover both function names: the exact PostgreSQL result matches, while the rounded Float64 result does not.
Testing
-Werror