Keep localized and reference sidebars intact - #353
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b19b540. Configure here.
Addresses review feedback on #353
|
🕵
|
The Session Settings landing page could render open and then immediately close when an older deployment had saved the same structural sidebar hash with that group closed. Version the persisted-state hash so the corrected landing-page behavior gets a clean initial state once, while subsequent user disclosure choices remain persistent.\n\nReported at: https://clickhouse-docs-ubnjtonbh-clickhouse.vercel.app/docs/reference/settings/session-settings
Landing groups received padding from both their shared row and their page link, which indented Session Settings, MergeTree tables settings, and Format Settings beneath Server Settings. Keep the wrapper unpadded and use the same 16px label inset as Mintlify.\n\nCompared:\nhttps://clickhouse-docs-a6wbm0uvo-clickhouse.vercel.app/docs/reference/settings/session-settings\nhttps://clickhouse.com/docs/reference/settings/session-settings
Treat a click on a group landing page as an explicit request to open that group before Astro preserves disclosure state for navigation. This prevents a default-closed state from immediately collapsing Session Settings on its landing page. Also align landing-group caret padding with ordinary disclosure rows.\n\nCompared:\nhttps://clickhouse-docs-nvneayipx-clickhouse.vercel.app/docs/reference/settings/session-settings\nhttps://clickhouse.com/docs/reference/settings/session-settings
Blargian
added
docs-translations-all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several regressions discovered while validating the split English and localized Vercel deployments:
Reported examples:
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Not applicable.