Skip to content

Request full graph fields in the caller walkthrough - #958

Merged
zlareb1 merged 9 commits into
mainfrom
docs/code-lookup-source-audit
Nov 21, 2026
Merged

zlareb1 merged 9 commits into
mainfrom
docs/code-lookup-source-audit

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Changelog entry

The caller and impact walkthrough requests the full MCP result fields it asks readers to verify.

Why

Compact MCP caller results can omit edge kinds, confidence and false truncation flags. The walkthrough requires those fields, so its requests need the existing full-output control.

Scope and risk

One documentation page adds explain: true inside both graph requests and explains its effect. The caller check is independent of the preceding fast-tier definition check and verifies each returned tier against its own indexed revision. Graph depth and row caps, source comparisons, uncertainty checks and missing-evidence stop conditions remain intact.

This changes no runtime, authorization, index coverage or tool selection behavior. The same page sets a factual title and description for MCP code search and caller graphs. Its H1, opening paragraph and agent-readable summary remain unchanged. This is discoverability work, not a performance or recommendation claim.

Compatibility, rollout and rollback

No wire, default, operator or data change. Current and released source support the generic MCP full-output control for these operations. Reverting removes the request flag and explanation.

Tests

  • Cached Prettier, the prose checker, JSON syntax and whitespace checks pass for the changed page.
  • Source checks cover the generic MCP wrapper, argument handling and both output-shaping stages in current, deployed and released source.
  • Bounded read-only MCP calls returned the required fields with the control. Indexed watermarks changed during that sequence, so it does not qualify the full freshness walkthrough. The separate fast-tier definition and fresh-session checks remain unrun.
  • No local test suite, model or provider evaluation ran. Full required PR CI must pass before merge.

The prior 0d18103080 full CI failed a Java parser-linearity check. Its cause remains unestablished. The metadata changes no parser or timing gate and is not claimed as a fix; complete new-head CI remains required. No unchanged-head CI rerun was requested.

Main includes the replicated-erasure fixture's lease-table repair from #1076. This PR uses main's exact fixture and changes no test or erasure source; the standalone fixture regression remains in #1077. The use-case page is byte-identical to the previously reviewed feature. Full CI and fresh independent reviews must qualify this new composition.

A timeout stack sample showed Markdown token construction before the unit worker was reported exited with SIGSEGV. The cause remains unknown; no checker change, timeout change, skip or unchanged-head rerun is included. A later successful run would not establish the original cause.

The 2cc9c9bd83 composition also lost its translations-check worker to SIGSEGV before teardown. Its native fault location and cause remain unknown. This composition changes no checker or runtime and is not claimed as its fix.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the documentation and checked the MCP source contracts.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full required PR CI passes.
  • No generated input, runtime, migration, plugin or frontend change.
  • The existing graph limits and uncertainty checks are preserved.
  • Public text contains no internal deployment details or unsupported success claim.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 11:58pm UTC

Request Review

Build this guide with the documentation application used by previews.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The fixture repair is on main. Its standalone regression remains in #1077; the feature diff retains its original tests.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The documentation branch needs the shared workflow checks and checkout credential controls before its final CI qualification.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit 6332e58 into main Nov 21, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant