Repository navigation
Request full graph fields in the caller walkthrough - #958
Merged
Merged
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Build this guide with the documentation application used by previews. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The fixture repair is on main. Its standalone regression remains in #1077; the feature diff retains its original tests. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The documentation branch needs the shared workflow checks and checkout credential controls before its final CI qualification. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry
The caller and impact walkthrough requests the full MCP result fields it asks readers to verify.
Why
Compact MCP caller results can omit edge kinds, confidence and false truncation flags. The walkthrough requires those fields, so its requests need the existing full-output control.
Scope and risk
One documentation page adds
explain: trueinside both graph requests and explains its effect. The caller check is independent of the preceding fast-tier definition check and verifies each returned tier against its own indexed revision. Graph depth and row caps, source comparisons, uncertainty checks and missing-evidence stop conditions remain intact.This changes no runtime, authorization, index coverage or tool selection behavior. The same page sets a factual title and description for MCP code search and caller graphs. Its H1, opening paragraph and agent-readable summary remain unchanged. This is discoverability work, not a performance or recommendation claim.
Compatibility, rollout and rollback
No wire, default, operator or data change. Current and released source support the generic MCP full-output control for these operations. Reverting removes the request flag and explanation.
Tests
The prior
0d18103080full CI failed a Java parser-linearity check. Its cause remains unestablished. The metadata changes no parser or timing gate and is not claimed as a fix; complete new-head CI remains required. No unchanged-head CI rerun was requested.Main includes the replicated-erasure fixture's lease-table repair from #1076. This PR uses main's exact fixture and changes no test or erasure source; the standalone fixture regression remains in #1077. The use-case page is byte-identical to the previously reviewed feature. Full CI and fresh independent reviews must qualify this new composition.
A timeout stack sample showed Markdown token construction before the unit worker was reported exited with SIGSEGV. The cause remains unknown; no checker change, timeout change, skip or unchanged-head rerun is included. A later successful run would not establish the original cause.
The
2cc9c9bd83composition also lost its translations-check worker to SIGSEGV before teardown. Its native fault location and cause remain unknown. This composition changes no checker or runtime and is not claimed as its fix.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the documentation and checked the MCP source contracts.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist