Skip to content

Coding-agent hooks use the configured complete MCP endpoint - #770

Open
zlareb1 wants to merge 26 commits into
mainfrom
fix/plugin-directory-endpoint
Open

zlareb1 wants to merge 26 commits into
mainfrom
fix/plugin-directory-endpoint

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Changelog category

  • Backward Incompatible Change

Changelog entry

The Claude Code plugin's server_url option takes a complete MCP URL. The separate toolset option is removed; choose the toolset in the URL query. Origin-only configurations require reconfiguration before hooks can contact Loom.

Why

The plugin directory accepts one configuration reference for an MCP URL. Hooks and the header helper must use that configured endpoint, including its reverse-proxy prefix. Checkout context travels separately so concurrent sessions retain their own credentials and repository scope.

Scope and risk

Endpoint validation, private checkout-context handoff, installer and dashboard commands, doctor remediation, setup documentation, mirrored helpers and tests. Both plugin versions advance to 1.2.46. Codex retains its fixed MCP entry. Main supplies the isolated erasure-fixture lease store from #1076. This feature uses that exact fixture and adds no erasure-fixture delta; its standalone regression stays in #1077.

The checkout-context file contains cwd, session ID and native client process identity, without tokens or transcripts. It survives session end and is eligible for best-effort pruning after a day without a write. The disclosures describe the private file and bounded native process queries. Codex skips both. Invalid explicit endpoints refuse hook network work without echoing credentials or choosing another destination. The helper does not control the client's own unauthenticated MCP or OAuth requests.

Compatibility, rollout and rollback

  • Server wire operations and schema: none.
  • Plugin configuration break: server_url means the complete MCP URL; the separate toolset option is retired. Reconfigure affected installations to a quoted /mcp?toolset=coding URL or supported union.
  • Older dashboards can emit origin-only commands during a rolling upgrade. The reconfiguration notice applies until those installations are corrected; no silent fallback is added.
  • Rollback: revert the plugin change and reconfigure affected installations to the restored option contract.

Tests

  • On f4d5a40505, 28 focused endpoint, project and option tests pass without failures or skips. Their feature source remains byte-identical in this composition. Plugin mirror and whitespace checks pass; complete new-head CI remains required.
  • The current-main composition preserves the session-end deadline repair and both cleanup clock fixtures. Only the paired version differs across the 57 previously reviewed feature paths.
  • Earlier native platform timing, cleanup and credential/scope failures remain recorded with their causes unresolved. Diagnostic changes retain the existing assertions, workloads and timing bounds.
  • Complete hosted CI, native platform checks and fresh whole-head reviews remain required on the final pushed head. Previous-head results do not qualify this composition.
  • The required model-based plugin evaluation has not run. Merge requires a passing result.

Focused reproduction: node --test integrations/claude-code-plugin/tests/mcp-project.test.mjs integrations/claude-code-plugin/tests/mcp-endpoint.test.mjs integrations/claude-code-plugin/tests/plugin-options.test.mjs.

AI assistance in the code

  • AI-generated: Codex implemented the plugin changes and checked local client contracts.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Both plugin manifests and generated mirrors agree.
  • The disclosure covers checkout state and native process queries.
  • Commits are signed off.
  • Complete final-head hosted CI and native platform checks pass.
  • Fresh final-head independent reviews have no findings.
  • The required model-based plugin evaluation passes.

Derive hook URLs and toolset guidance from the endpoint used by directory
installs. Pass checkout context through private state keyed to the client
process instead of a URL fragment.

Retire the standalone toolset option. Origin-only server_url installations
must configure /mcp and the desired query. Invalid configuration prints an
actionable notice without sending Loom credentials.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The endpoint query must stay one literal argument in shells that reject unmatched globs.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Standalone plugin pages need the local process commands and retention rules for the Claude checkout artifact. Keep the installed endpoint contract test aligned with the complete URL option.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Separate the Claude endpoint selection from the generic environment and file URL lookup in the shared helper comment.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signup uses the same resolved base as the endpoint transport so repeated path separators reach the configured proxy route and remain in saved configuration.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Generic and fixed clients accept control-plane origins. Restrict complete-endpoint parsing and install state to the configurable endpoint client so startup retains its primer and collection reads.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Save a credential-free invalid marker before startup refuses a malformed endpoint so the standalone diagnostic cannot report success against an older server.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Match the manifest expansion when the environment base ends in a slash. Reject distinct supplied bases and retain their separators in credential-source warnings.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the endpoint option contract and the shared session-protection changes together. Both plugin manifests use the next unclaimed version.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
No context write can resolve an absent client ancestor. Keep bounded waiting for identified clients and describe URL precedence for each hook family.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the paired plugin version at 1.2.34 and preserve the merged hook labels.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The Intel run did not expose whether the accounting bound used wall or CPU time, or whether the reporting child exited normally. Keep the existing assertions and timing limits while recording bounded diagnostics.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the diagnostic object in the repository formatter's multiline layout.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The native assertion did not distinguish a crossed pair from missing fields. Keep the every-pair guard and report only fixed category counts, without captured header values.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 11:04pm UTC

Request Review

Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep proxy prefixes and query toolsets while carrying checkout identity separately.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Replicated erasure tests need a private lease table for fenced inserts.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The fixture repair is on main. Its standalone regression remains in #1077; the feature diff retains its original tests.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant