Repository navigation
A tree-less Thrift IDL lane in the code index #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahulsjha
wants to merge
18
commits into
ClickHouse:main
Choose a base branch
from
rahulsjha:feat/thrift-lane
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+950
−16
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c0a0ba0
feat(code): a tree-less Thrift IDL lane
rahulsjha 3665dc7
test: give the Thrift fixtures a test-inventory workflow
rahulsjha 0d527c9
docs: format the language-support table with prettier
rahulsjha 26ab218
Merge remote-tracking branch 'origin/main' into feat/thrift-lane
rahulsjha e78d117
fix(code): read Thrift includes from the comment-aware tokens
rahulsjha 3ee5f74
test: format the Thrift include test with ruff
rahulsjha 56d86c5
fix(thrift): read field types when the numeric field ID is absent
rahulsjha 7c4f783
Merge remote-tracking branch 'origin/main' into feat/thrift-lane
rahulsjha 2402850
test(thrift): cover struct, argument and throws fields without a nume…
rahulsjha 920ce3d
Move the Thrift fixture out of the plain-text cases
rahulsjha 7a6e02a
Merge remote-tracking branch 'origin/main' into feat/thrift-lane
rahulsjha 96be03c
Replicated erasure fixtures provide isolated write leases
zlareb1 4a77a5c
Thrift definitions join code search and traversal
zlareb1 44dd513
Replicated erasure fixtures provide their required lease table
zlareb1 abf0ebc
Thrift references survive root files and nested field syntax
zlareb1 27c51f0
Preserve current documentation in the Thrift composition
zlareb1 74f72ee
Thrift type metadata stays out of dependency sites
zlareb1 9e25140
Use the replicated-erasure fixture supplied by main
zlareb1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,6 @@ | |
| ".purs", | ||
| ".re", | ||
| ".hx", | ||
| ".thrift", | ||
| ".avsc", | ||
| ".capnp", | ||
| ".asm", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.