Skip to content

Catalog-copy failures retain bounded send context - #1101

Open
zlareb1 wants to merge 1 commit into
mainfrom
test/catalog-send-failure-context
Open

zlareb1 wants to merge 1 commit into
mainfrom
test/catalog-send-failure-context

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 21, 2026

Copy link
Copy Markdown
Member

Related: #960

Changelog category (leave one):

  • CI Fix or Improvement

Changelog entry

Not required.

Why

A catalog-copy integration test can fail during its catalog INSERT before reaching the injected delete cutoff. The public retryable error suppresses the original ClickHouse exception, leaving the underlying error code and carried-column snapshot unavailable.

The test records a fixed exception category, bounded numeric code, and the already available stored-column count and fingerprint when that send fails. It adds the context to the outward exception and raises the same object. This supplies missing evidence; the cause of the observed refusal remains unknown.

Scope and risk

Only the existing retry-copy test and its focused fake-boundary controls change. The observer calls the original sender with the same arguments and preserves its return value and exception. It performs no additional read, connection, write, retry, or worker attempt. Diagnostic notes contain no exception text, SQL, payload, token, identity, or column names.

The original cutoff, retry, deletion and final-row assertions remain. Production code, the carry fence, leases and deadlines are unchanged.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: reverting removes test diagnostics and controls; no stored data or generated files change.

Tests

The actual integration case, driven through fake boundaries, failed first in eight diagnostic controls while three behavior controls passed. The final 13 focused controls passed in 0.77s with python -m pytest tests/unit/test_knowledge_move_failure_context.py -q -p no:randomly. Scoped Ruff, formatting, prose, whitespace and AST preservation checks passed. Full hosted CI and a fresh independent whole-diff review are required on the final pushed head before merge.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the diff and checked the send path, exception identities, metadata bounds and original assertion preservation.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full repository gates pass in hosted CI; only small directly related checks ran locally.
  • No generated files, migration, plugin package, frontend or documentation page changed.
  • No operator steps or wire changes.
  • Repository text contains no operational identities or private source contents.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 3:09am UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant