Repository navigation
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #960
Changelog category (leave one):
Changelog entry
Not required.
Why
A catalog-copy integration test can fail during its catalog INSERT before reaching the injected delete cutoff. The public retryable error suppresses the original ClickHouse exception, leaving the underlying error code and carried-column snapshot unavailable.
The test records a fixed exception category, bounded numeric code, and the already available stored-column count and fingerprint when that send fails. It adds the context to the outward exception and raises the same object. This supplies missing evidence; the cause of the observed refusal remains unknown.
Scope and risk
Only the existing retry-copy test and its focused fake-boundary controls change. The observer calls the original sender with the same arguments and preserves its return value and exception. It performs no additional read, connection, write, retry, or worker attempt. Diagnostic notes contain no exception text, SQL, payload, token, identity, or column names.
The original cutoff, retry, deletion and final-row assertions remain. Production code, the carry fence, leases and deadlines are unchanged.
Compatibility, rollout and rollback
Tests
The actual integration case, driven through fake boundaries, failed first in eight diagnostic controls while three behavior controls passed. The final 13 focused controls passed in 0.77s with
python -m pytest tests/unit/test_knowledge_move_failure_context.py -q -p no:randomly. Scoped Ruff, formatting, prose, whitespace and AST preservation checks passed. Full hosted CI and a fresh independent whole-diff review are required on the final pushed head before merge.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the diff and checked the send path, exception identities, metadata bounds and original assertion preservation.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist