Repository navigation
Conversation
Audit evidence follows its dedicated deployment retention window. Keep namespace warm tiering while removing inherited namespace deletion TTLs. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1056
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Namespace retention no longer expires audit records. Audit deletion follows only the dedicated audit retention setting, which defaults to keeping records indefinitely.
Why
A namespace's memory lifetime also controlled its audit evidence. A short memory-retention window could therefore remove the record of a deletion or a retirement reversal. Audit evidence needs its own retention decision.
Scope and risk
The retention builder ignores namespace deletion windows for
audit_logwhile preserving namespace warm-tier moves and explicit deployment audit retention. Reconciliation removes an inherited audit TTL or replaces it with the dedicated audit window. Documentation and generated settings descriptions state that boundary.Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex; independent review checked retention composition, inherited TTL removal, tiering, callers, tests and generated settings.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist