Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/private-log-capture-observation
branch
from
November 21, 2026 00:08
5a604a2 to
0f5fe33
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry
Not required.
Why
The private native-query test observes a process-wide capture file while awaiting one private query. A public query from an existing task can create that file and fail the private-capture assertion without capturing private SQL. An event-controlled unit harness reproduces this through the original integration coroutine; the failing file contains only the unrelated public statement. The writer responsible for the original hosted failure remains unknown.
The fixture scopes its observation with an inherited context variable. The request and its child tasks retain the capture boundary; unrelated tasks keep the original capture sink. Forced private captures from the request or a child still fail the original absence assertion.
Scope and risk
Only the integration test's capture observer and its unit regression change. The private result, file-absence assertion, public capture control, native query-log proof, SQL-user permissions and insights permissions remain unchanged. The unit harness stops before native database checks; it does not qualify those checks locally.
Compatibility, rollout and rollback
Tests
This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the test fixture and regression. Source review checks the inherited privacy scope, original sink preservation and unchanged native and permission assertions.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist