Skip to content

Do not retain checkout credentials in read-only test jobs - #1078

Merged
zlareb1 merged 4 commits into
mainfrom
ci/read-only-checkout-credentials
Nov 20, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
ci/read-only-checkout-credentials

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: none.

Changelog category

  • CI Fix or Improvement

Why

Read-only test jobs do not need Git credentials after checkout. Disable credential persistence in sixteen CI checkout steps and three plugin-platform checkout steps so later dependency installs and tests cannot use a leftover Git authentication configuration.

Scope and risk

The credential change alters only checkout inputs. These workflows retain repository read access and run their existing test commands. There is no demonstrated credential disclosure; this is least-privilege hardening identified by an offline workflow audit.

The translation updater retains its existing authenticated push path. Release publication and dependency locks are unchanged. No tools, accounts, runners, schedules, caches or artifact uploads are added.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: revert the checkout inputs.

Tests

  • actionlint v1.7.12 validates every workflow with -shellcheck= -pyflakes=.
  • Parsed before/after workflow comparison confirms the nineteen credential inputs are the only semantic changes, and every checkout in these two read-only workflows disables persistence.
  • Offline zizmor v1.32.0 reports nineteen fewer credential-persistence findings. Two remain in the separately owned translation workflow, including the required authenticated push job; the audit is not claimed clean. Other findings retain their source-specific dispositions.
  • git diff --check and the prose checker pass.
  • Full hosted CI passes on this head, including the actual checkouts, platform jobs and repository gates.

AI assistance in the code

  • AI-generated (an agent wrote most of the diff): Codex. Checked every checkout input, the unchanged job commands and the before/after audit results.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full format, lint, typecheck and unit gates pass in hosted CI before merge.
  • No generated files, migrations, plugin behavior, frontend files or wire fields change.
  • Repository text passes the prose check.
  • Commits are signed off.

Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Dependency installs and tests do not need Git authentication after checkout. Disable persistence while keeping the job token read-only.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 11:03pm UTC

Request Review

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the tooling change limited to workflow configuration. The separate fixture regression remains in its own pull request.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit b2a271e into main Nov 20, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant