Repository navigation
Do not retain checkout credentials in read-only test jobs - #1078
Merged
Merged
Conversation
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Dependency installs and tests do not need Git authentication after checkout. Disable persistence while keeping the job token read-only. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the tooling change limited to workflow configuration. The separate fixture regression remains in its own pull request. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: none.
Changelog category
Why
Read-only test jobs do not need Git credentials after checkout. Disable credential persistence in sixteen CI checkout steps and three plugin-platform checkout steps so later dependency installs and tests cannot use a leftover Git authentication configuration.
Scope and risk
The credential change alters only checkout inputs. These workflows retain repository read access and run their existing test commands. There is no demonstrated credential disclosure; this is least-privilege hardening identified by an offline workflow audit.
The translation updater retains its existing authenticated push path. Release publication and dependency locks are unchanged. No tools, accounts, runners, schedules, caches or artifact uploads are added.
Compatibility, rollout and rollback
Tests
-shellcheck= -pyflakes=.git diff --checkand the prose checker pass.AI assistance in the code
AI-generated (an agent wrote most of the diff): Codex. Checked every checkout input, the unchanged job commands and the before/after audit results.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist