Repository navigation
Validate workflow syntax and expressions on pull requests - #1075
Merged
Merged
Conversation
Reject invalid expressions, job dependencies and permissions before workflow jobs run. The validator uses a versioned archive with a fixed checksum and needs only repository read access. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the tooling change limited to workflow configuration. The separate fixture regression remains in its own pull request. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: none.
Changelog category
Why
Workflow expressions, job dependencies and permissions need validation before a job runs. An actionlint check fails on invalid workflow semantics alongside the existing security analysis.
Scope and risk
One workflow checks every workflow file on pull requests and pushes to supported branches. It downloads a versioned release archive, verifies its fixed SHA256 before extraction, and runs the validator without executing repository scripts. The checkout has read access and does not retain credentials. No secrets, additional accounts, caches or artifact storage are used. Standard hosted runners are free for public repositories. The job has a five-minute limit and no schedule.
The check covers actionlint's native workflow validation. Optional shellcheck and pyflakes integrations are disabled so host-installed tools do not change its scope. No diagnostic is ignored and no baseline is introduced.
Compatibility, rollout and rollback
Tests
-shellcheck= -pyflakes=.git diff --checkand the prose check pass.AI assistance in the code
AI-generated (an agent wrote most of the diff): Codex. Checked the workflow, upstream checksum, read-only token scope and the valid and invalid validator inputs.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist