Skip to content

Validate workflow syntax and expressions on pull requests - #1075

Merged
zlareb1 merged 4 commits into
mainfrom
ci/free-workflow-security
Nov 20, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
ci/free-workflow-security

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: none.

Changelog category

  • CI Fix or Improvement

Why

Workflow expressions, job dependencies and permissions need validation before a job runs. An actionlint check fails on invalid workflow semantics alongside the existing security analysis.

Scope and risk

One workflow checks every workflow file on pull requests and pushes to supported branches. It downloads a versioned release archive, verifies its fixed SHA256 before extraction, and runs the validator without executing repository scripts. The checkout has read access and does not retain credentials. No secrets, additional accounts, caches or artifact storage are used. Standard hosted runners are free for public repositories. The job has a five-minute limit and no schedule.

The check covers actionlint's native workflow validation. Optional shellcheck and pyflakes integrations are disabled so host-installed tools do not change its scope. No diagnostic is ignored and no baseline is introduced.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none. The check starts when the workflow is present on a pull request.
  • Rollback: revert the workflow file.

Tests

  • actionlint v1.7.12 validates all repository workflows with -shellcheck= -pyflakes=.
  • Negative controls reject an undefined matrix property, a missing job dependency and an invalid permission; a valid matrix expression passes.
  • The release archive SHA256 matches the upstream release metadata.
  • git diff --check and the prose check pass.
  • Full repository suites pass in hosted CI on this head.

AI assistance in the code

  • AI-generated (an agent wrote most of the diff): Codex. Checked the workflow, upstream checksum, read-only token scope and the valid and invalid validator inputs.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full format, lint, typecheck and unit gates pass in hosted CI before merge.
  • No generated files, migrations, plugin behavior, frontend files or wire fields change.
  • Repository text passes the prose check.
  • Commits are signed off.

Reject invalid expressions, job dependencies and permissions before workflow jobs run. The validator uses a versioned archive with a fixed checksum and needs only repository read access.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 11:03pm UTC

Request Review

Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the tooling change limited to workflow configuration. The separate fixture regression remains in its own pull request.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit 5bc0481 into main Nov 20, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant