Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
refactor/single-npm-package
branch
3 times, most recently
from
November 20, 2026 21:14
fd8ae44 to
809aa32
Compare
9 tasks done
zlareb1
force-pushed
the
refactor/single-npm-package
branch
3 times, most recently
from
November 20, 2026 23:55
7cd3371 to
dac8e34
Compare
Bundle the native n8n nodes in @clickhouse/loom and publish them through the SDK release workflow. Qualify the packed artifact with an isolated n8n host and record the single-package release policy. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Keep the adapter toolchain on UUID 11.1.1 when moving it into the shared SDK. Check that its UUID helper rejects an undersized output buffer. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
The SDK scan includes the moved n8n history adapter. Review its identity-bound list, get and delete payloads and pin their scope builders without changing content-write admission. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
refactor/single-npm-package
branch
from
November 21, 2026 00:02
dac8e34 to
8ee5397
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
The
@clickhouse/loomnpm package includes the native n8n nodes and credentials alongside the TypeScript SDK and its framework adapters. Self-hosted n8n loads the nodes throughN8N_CUSTOM_EXTENSIONS.Why
All JavaScript integrations need one package version and one publication path. A separate n8n package requires its own registry setup and trusted publisher. The SDK build can include the native files and validate them before its existing publisher uploads the tarball.
The tradeoff is installation through n8n's custom-node directory: its Community Nodes settings installer requires an
n8n-nodes-package name. The setup documentation gives the shared-package command. The adapter targets self-hosted n8n.Scope and risk
Move the n8n source, icons, licenses and behavior tests into the TypeScript SDK. Export the classes through
@clickhouse/loom/integrations/n8nand emit the CommonJS files that the native loader expects. Remove the standalone package, its publishing workflow and its unused node-CLI toolchain patch.n8n-workflowremains an optional host peer. Plain SDK installs gain no required runtime dependencies. The tarball tests check this in a clean consumer, then install a locked n8n host and exercise the native files and both module formats. Separate test installs accommodate the frameworks' different Zod requirements. SDK builds skip dependency lifecycle scripts because the host expression engine is not used by these adapter tests.The n8n framework keeps its UUID 11.1.1 override when moving into the SDK; a regression test checks that undersized UUID output buffers are rejected.
The artifact grows to include the native bundles. Packaging, module loading and host dependency resolution are the main risks. The sender census classifies history listing, lookup and deletion as identity-bound references and pins their identity builders; message content writes retain their admission class. The release skill, release documentation and publisher contract test record the single-package policy. Generated documentation and the operation reach manifest follow the source move.
Compatibility, rollout and rollback
@clickhouse/loomin the npm project running n8n, setN8N_CUSTOM_EXTENSIONSto its bundled node directory, and restart each n8n worker. The documentation includes the commands. No migration or backfill is required.Tests
make format-check,make lint,make typecheck.npm --prefix sdk/typescript run checkandnpm --prefix sdk/typescript run check:dist: source tests, README examples, native adapter tests against the packed tarball, publint and declaration resolution.npm exec --yes --package=node@22 -- node scripts/test-n8n.mjsfromsdk/typescript: the packed artifact loads and the adapter tests pass on Node 22.pytest tests/unit/test_install_script.py -q: 212 passed, one platform skip.pytest bench -q: 251 passed.make test-unitrun encounters SQL and parser failures. Representative failures reproduce on unchangedmain; the local ClickHouse binary does not support the schema'senable_quantized_codecsetting. CI runs the full suite on the supported environment.ENOTEMPTYduring test-directory cleanup. The unchanged hook contract test waits for parent hooks but can race detached hook work.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the packaging changes and checked the artifact contents, adapter behavior, module resolution and generated files with the commands above.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed. Local full-suite limitations are listed above; CI must pass before merge.