Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Use the signed-in account to check and add selected document links. Keep shared credentials limited to administrators and show provider configuration requirements. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Refresh source items before another edit after an uncertain save and return focus to the source list. Keep the phone action label compact and cover connected-account permissions at both entrypoints. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Use stored access policy for retirement confirmation and count reporting. Keep the source return marker during account-page navigation and align browser fixtures with the connected-account default. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
feat/connected-account-source-ui
branch
from
November 20, 2026 21:09
fdfc80b to
e8ceb7d
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category
Changelog entry
Add and edit document sources from a connected Drive, Notion or Linear account in the Library and repository views. Preview pasted links, check access, manage the connection and recover from an interrupted save without losing the link draft.
Why
A signed-in writer with a connected account needs to select content without entering a shared credential. Source controls also need canonical ownership from the server so an alternate token subject cannot hide the owner's actions or expose another user's controls.
Scope and risk
Settings displays account and consent-configuration state. The source form previews each selected link, requires a current access check and invalidates that result when the account, caller, destination or selection changes. Source rows show sync state and document counts. Item edits use the existing incremental update operation; an unconfirmed save requires a fresh source read and another review before the next write. Pending saves cannot be dismissed. Closing an editor refreshes its items before mutation actions return and restores focus to the source list. Manual refresh retains the rows and keyboard focus, announces the read as busy and ignores repeated presses until it settles. The phone Add action keeps its full accessible name with a shorter visible label. Account-page navigation preserves the source return marker while stripping unrelated query parameters. Retirement confirmation uses stored access: mirrored copies always queue retirement, namespace copies keep the explicit opt-in, and unavailable access policy makes no retention or count promise.
The server projects connection availability and source ownership through existing account and authorization checks. The frontend discards cached ownership when the caller changes. Provider permissions and ingestion results remain server decisions. Account errors preserve input and offer an explicit recovery action.
Compatibility, rollout and rollback
connection.listentries add required booleanconnect_available.knowledge.source.listentries addowned_by_caller. The generated nested list-output type changes fromKnowledgeSourceEntrytoKnowledgeSourceListEntry; the new field is optional in generated clients. No compatibility alias is added.knowledge.source.parse_links,knowledge.source.addandknowledge.source.updateoperations. Their request contracts and access-mode rules do not change.Tests
On parent
bcff2d313b, selected component groups passed 102, 19 and 83 cases (204 total), and the two selected backend modules passed 33 cases. Production build and bundle budget passed; applicable generated outputs were regenerated and reviewed. Full hosted CI finished with 54 successful and two skipped checks. The current head merges current main without changing any of the 35 topic-file blobs. Fresh independent source review and full hosted CI on that combined tree are pending.Reproduce the selected checks from the repository root:
The selected local browser attempt stopped at its memory guard before a case completed. Hosted browser checks on parent
bcff2d313bpassed the connected-source flow at desktop and phone widths, plus repository reader and administrator scenarios. Browser checks on the new combined tree remain pending. A genuine signed-in provider flow and native-client privacy qualification remain unverified. Full hosted CI must pass before merge.AI assistance in the code
AI-generated: Codex wrote most of the diff. The source review checked authorization and canonical ownership, stale account/check invalidation, ordered link previews, interrupted-save recovery and generated contracts. Selected regressions and the production build were verified separately.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist