Skip to content

Limit cell trigger statement timings to their measured scope - #1063

Merged
zlareb1 merged 4 commits into
mainfrom
docs/cell-trigger-measurement-claims
Nov 21, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
docs/cell-trigger-measurement-claims

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: #795

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Why

The trigger-cost report inferred API latency and delivery-throughput acceptance from statement timings. Those timings omit the rest of both workloads, and the following report already says neither gate is established. The linked architecture page repeats the prediction and describes shipping from statement-level evidence. Remove both unsupported inferences and point to the acceptance workload.

Scope and risk

The English benchmark report and its linked architecture explanation. Existing measurements, reproduction commands and acceptance limits remain intact. Translations follow the existing automation.

Compatibility, rollout and rollback

No wire changes or operator steps. Reverting restores the earlier wording; no stored data changes.

Tests

  • Exact replacement check: all bytes outside the two paragraph corrections are preserved.
  • git diff --check: pass.
  • Scoped prose check: pass.
  • An earlier source passed its independent entire-source review but failed the directory-cleanup unit test. Its other checks do not qualify this source.
  • The merged directory-cleanup fixture repair is included. Both paragraph corrections remain intact on that source; the pull request still changes only the two documentation pages.
  • Fresh independent entire pushed-source review found no source issues or nits. All 49 required hosted checks passed, including both Postgres memory-authority integration jobs; the two documentation publication skips are expected. No timing cause is assumed.
  • No benchmark or heavy local suite run. All required hosted gates must pass before merge.

The preceding published head failed the two replicated-erasure integration cases because their isolated database lacked _migration_lock; fenced memory writes could not read the lease holder. This head includes the landed fixture repair. Both corrected documentation pages remain byte-identical to the preceding head. The failed cohort remains recorded. The fresh independent entire-source review and all required hosted checks passed for this composition; earlier results do not qualify it.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the wording; the statement-cost and end-to-end acceptance descriptions were checked together.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required hosted format, lint, typecheck and unit checks pass.
  • Generated files, schema, plugins and frontend do not change.
  • Docs describe the measured scope and required acceptance workload.
  • Changed repository text contains no dates, people, hosts or internal namespaces.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 11:51pm UTC

Request Review

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Compose the merged directory cleanup clock repair required by the previous unit failure while preserving both measured-scope documentation corrections.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The integration fixture provisions the lease table used by fenced memory clearing.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 marked this pull request as ready for review November 21, 2026 01:11
@zlareb1
zlareb1 merged commit 57bb982 into main Nov 21, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant