Repository navigation
Limit cell trigger statement timings to their measured scope - #1063
Merged
Merged
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 of 7 tasks
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Compose the merged directory cleanup clock repair required by the previous unit failure while preserving both measured-scope documentation corrections. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The integration fixture provisions the lease table used by fenced memory clearing. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
marked this pull request as ready for review
November 21, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #795
Changelog category (leave one):
Why
The trigger-cost report inferred API latency and delivery-throughput acceptance from statement timings. Those timings omit the rest of both workloads, and the following report already says neither gate is established. The linked architecture page repeats the prediction and describes shipping from statement-level evidence. Remove both unsupported inferences and point to the acceptance workload.
Scope and risk
The English benchmark report and its linked architecture explanation. Existing measurements, reproduction commands and acceptance limits remain intact. Translations follow the existing automation.
Compatibility, rollout and rollback
No wire changes or operator steps. Reverting restores the earlier wording; no stored data changes.
Tests
git diff --check: pass.The preceding published head failed the two replicated-erasure integration cases because their isolated database lacked
_migration_lock; fenced memory writes could not read the lease holder. This head includes the landed fixture repair. Both corrected documentation pages remain byte-identical to the preceding head. The failed cohort remains recorded. The fresh independent entire-source review and all required hosted checks passed for this composition; earlier results do not qualify it.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the wording; the statement-cost and end-to-end acceptance descriptions were checked together.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist