Repository navigation
Conversation
Specify fresh proof sessions, private transport ownership and failure disposal before implementing bounded reuse. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep one idle channel per client while rebuilding each checked session and discarding failed, replaced or active-child transports. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
marked this pull request as ready for review
November 20, 2026 16:24
7 tasks done
A pending passive effect can clear a request before its loading state commits. Hand focus over in a layout effect and reproduce the lost request before passive effects flush. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
7 of 9 tasks
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Depends on: #1062
Changelog category (leave one):
Changelog entry
Coordination proofs reuse one idle private transport per client while keeping fresh named sessions and live authority checks.
Why
Constructing a private transport for every proof repeats driver initialization and server metadata reads. Retaining one idle transport avoids that repeated construction. Each proof still creates a separate named session and bootstrap; transport reuse retains no authority result.
Scope and risk
The branch includes the separately reviewed pagination-focus dependency above so the combined source receives CI. That dependency must qualify and merge before this PR; the transport change itself remains three files.
The client retains at most one idle channel bound to its original driver, generation and connection configuration. Concurrent proofs own distinct transports. Failed, poisoned, cancelled, replaced and nonquiescent scopes discard their channels. Disconnect closes idle state and refuses new proofs while an active scope finishes.
Live backend, principal, Keeper, table and nonce checks retain their existing behavior. Statement and proof deadlines, admission capacity, query retries and cache settings retain their existing limits. No measured latency benefit or native acceptance result is established by the unit tests.
Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the change; independent source review checked ownership, cancellation, identity pins and the unchanged native proof.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist