Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
fix/restore-key-lock-clock
branch
3 times, most recently
from
November 20, 2026 23:04
5cb3c3a to
658be17
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/restore-key-lock-clock
branch
from
November 21, 2026 00:08
658be17 to
8b33a03
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Changelog category
Changelog entry
Not required.
Why
A restoration test can spend the fake key lock’s wait budget while acquiring an uncontended local lock, before reaching its restore assertions. These cases check restoration and duplicate visibility independently of CPU scheduling latency.
Scope and risk
Replicated-erasure lease provisioning and its unit regression controls are on main. This branch preserves them unchanged. It also scopes person-query observations to the authorization decision, retaining unbounded-read negative controls. No production authorization, lease or erasure rule changes.
The clock change stays in one unit-test file. The existing fake lock uses a private function loop whose clock advances during selector waits. The loop, key-lock budget, lease timers and fake table share that clock. Each case cancels and drains newly pending tasks and fails if it leaked one. A control verifies that a contended key lock still refuses at its idle deadline and releases its registry entry.
Every existing test body, assertion and deadline value is retained. Product behavior and shared test helpers are unchanged.
Compatibility, rollout and rollback
Tests
This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
.venv/bin/python -m pytest -q tests/unit/test_restore_unsupersede.py: 18 passed.AI assistance in the code
AI-generated: Codex wrote the fixture change and checked its clock boundaries, cancellation controls and task cleanup.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist