Skip to content

Use an assigned loopback port for the placement drill - #1047

Merged
zlareb1 merged 1 commit into
mainfrom
fix/placement-drill-port
Nov 20, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/placement-drill-port

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026

Copy link
Copy Markdown
Member

Related: #998

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry

Not required.

Why

The placement durability drill can fail before its tests start when its fixed host port is already occupied. Let the container runtime reserve a loopback port and pass that primary's actual mapping to the drill.

Scope and risk

Changes only placement-drill wiring and adds focused workflow regressions. Refuse empty, multiple, non-loopback or out-of-range mappings before running the tests. Existing resource guards, cleanup targets, memory limits, test selection and deadlines are preserved. The main database and shared startup helper are unchanged.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: reverting restores the fixed drill port; no persisted data changes.

Tests

Fifteen inert workflow cases cover assigned ports, rejected mappings, lookup and test failures, cleanup, and preexisting resource refusal. Local test admission was refused before execution; no local test success is claimed. Full hosted CI, including both database-version durability drills, is required before merge.

Focused reproduction: .venv/bin/python -m pytest -q tests/unit/test_cell_place_workflow.py.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the change. Source review and actual hosted CI remain required.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required format, lint, type and unit checks pass in hosted CI.
  • No generated files, migrations, plugin files, frontend files or documentation pages change.
  • Commits are signed off.

Read and validate the owned primary port mapping before constructing the drill DSN. Preserve resource guards and cleanup when mapping or tests fail.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 1:53pm UTC

Request Review

@zlareb1
zlareb1 merged commit 606496f into main Nov 20, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant