Repository navigation
Use an assigned loopback port for the placement drill - #1047
Merged
Merged
Conversation
Read and validate the owned primary port mapping before constructing the drill DSN. Preserve resource guards and cleanup when mapping or tests fail. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #998
Changelog category (leave one):
Changelog entry
Not required.
Why
The placement durability drill can fail before its tests start when its fixed host port is already occupied. Let the container runtime reserve a loopback port and pass that primary's actual mapping to the drill.
Scope and risk
Changes only placement-drill wiring and adds focused workflow regressions. Refuse empty, multiple, non-loopback or out-of-range mappings before running the tests. Existing resource guards, cleanup targets, memory limits, test selection and deadlines are preserved. The main database and shared startup helper are unchanged.
Compatibility, rollout and rollback
Tests
Fifteen inert workflow cases cover assigned ports, rejected mappings, lookup and test failures, cleanup, and preexisting resource refusal. Local test admission was refused before execution; no local test success is claimed. Full hosted CI, including both database-version durability drills, is required before merge.
Focused reproduction:
.venv/bin/python -m pytest -q tests/unit/test_cell_place_workflow.py.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the change. Source review and actual hosted CI remain required.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist