Repository navigation
Conversation
zlareb1
force-pushed
the
fix/claim-cancel-evidence-20261120
branch
2 times, most recently
from
November 20, 2026 22:25
c74ea94 to
00c9e87
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 of 5 tasks
zlareb1
force-pushed
the
fix/claim-cancel-evidence-20261120
branch
from
November 20, 2026 23:07
00c9e87 to
41806d6
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/claim-cancel-evidence-20261120
branch
from
November 21, 2026 00:08
41806d6 to
85f66ef
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Why
A claim-release cancellation failure can leave only the event-loop selector in its thread stack. That stack cannot distinguish a suspended prompt from retirement cleanup. The failed exit check also records bounded coroutine frames, cancellation counts, signal state and lifecycle counters from its owned child.
The cause of the cancellation failure remains unknown. This change supplies evidence; it does not fix command cancellation.
Scope and risk
Only the native-command test fixture changes. The trace retains its all-thread stack and adds at most eight tasks with eight frames each. Frame names and file names are capped at 64 characters, and an encoded packet above 32,700 bytes is replaced by a fixed truncation marker. Arguments, locals, task names, input, environment values and exception text are excluded. Observer errors emit a fixed failure marker when the trace remains writable.
The existing cancellation test adds diagnostics only after its five-second exit deadline has failed, then still fails the test. All 53 original assertions and the ten-second prompt deadline remain unchanged. The new coroutine collector and controls retain the prior thread-diagnostic version of all five test bodies, covering 14 cases. A separate control begins with an already-cancelled command suspended before cleanup; it tests the observer without adding another prompt-signal timing race.
Compatibility, rollout and rollback
Tests
.venv/bin/python -m pytest tests/unit/test_native_command_retirement.py -q -p no:randomly: 18 passed.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex; checked the signal path, output bounds, original test bodies and failure preservation.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed.git commit -s), as CONTRIBUTING.md asks.