Repository navigation
fix(deps): patch certificate-trust advisories - #1129
Merged
Merged
Conversation
Update rustls-webpki to 0.103.16 and webpki-root-certs to 1.0.10 for RUSTSEC-2026-0382 and RUSTSEC-2026-0383. Keep all other dependencies and manifest constraints unchanged. Fixes ClickHouse#1128
iskakaushik
approved these changes
Oct 22, 2026
balanza
pushed a commit
that referenced
this pull request
Oct 22, 2026
The security audit fails before 0.5.0 because the locked TLS dependencies can trust distrusted emSign intermediates. Update only `Cargo.lock`: - `rustls-webpki` 0.103.15 → 0.103.16 for [RUSTSEC-2026-0382](https://rustsec.org/advisories/RUSTSEC-2026-0382). - `webpki-root-certs` 1.0.9 → 1.0.10 for [RUSTSEC-2026-0383](https://rustsec.org/advisories/RUSTSEC-2026-0383). Both patches satisfy the existing dependency constraints and Rust 1.94 requirement. The `rustls-webpki` path is present in the Linux CLI runtime. The bundled-root dependency is WebAssembly-only through `rustls-platform-verifier`, but is covered by the whole-lockfile audit. The diff changes only the two package versions and checksums. Validation completed: - `cargo audit --deny warnings` with cargo-audit 0.22.2: passed locally and in [PR CI](https://github.com/ClickHouse/clickhousectl/actions/runs/39761820704/job/119767579310), 418 dependencies scanned. - `cargo fmt --all` and `git diff --check`: passed. - CLI clippy and tests, plus check and all-target clippy without default features: passed. - API/analyzer all-target clippy and tests: passed. - Python unit tests: 113 passed. - Rust 1.94: workspace/all-target checks, CLI/all-target checks without default features, and workspace/all-target/all-feature checks all passed. PR CI has finished: audit, CLI/API tests, Rust 1.94 checks, local Postgres edge cases, installation checks, and URL probes all passed. The required [Cloud integration decision](https://github.com/ClickHouse/clickhousectl/runs/119767618403) remains `ACTION_REQUIRED` because this is a fork PR; the fork cannot receive Cloud secrets. It needs the repository's approved trusted-mirror or maintainer decision process. No override has been applied. Fixes #1128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security audit fails before 0.5.0 because the locked TLS dependencies can trust distrusted emSign intermediates. Update only
Cargo.lock:rustls-webpki0.103.15 → 0.103.16 for RUSTSEC-2026-0382.webpki-root-certs1.0.9 → 1.0.10 for RUSTSEC-2026-0383.Both patches satisfy the existing dependency constraints and Rust 1.94 requirement. The
rustls-webpkipath is present in the Linux CLI runtime. The bundled-root dependency is WebAssembly-only throughrustls-platform-verifier, but is covered by the whole-lockfile audit. The diff changes only the two package versions and checksums.Validation completed:
cargo audit --deny warningswith cargo-audit 0.22.2: passed locally and in PR CI, 418 dependencies scanned.cargo fmt --allandgit diff --check: passed.PR CI has finished: audit, CLI/API tests, Rust 1.94 checks, local Postgres edge cases, installation checks, and URL probes all passed. The required Cloud integration decision remains
ACTION_REQUIREDbecause this is a fork PR; the fork cannot receive Cloud secrets. It needs the repository's approved trusted-mirror or maintainer decision process. No override has been applied.Fixes #1128.