Repository navigation
Conversation
ClickPipeBigQueryPipeSettings{,Response} gain syncCron, carried through the
TryFrom write-back. The CLI sends sync_cron: None, so its request is
unchanged (pinned by the existing CDC settings test).
Co-authored-by: Alasdair Brown <sdairs@users.noreply.github.com>
…/openapi-drift-1112-api-clickpipes-c05d Co-authored-by: Alasdair Brown <sdairs@users.noreply.github.com>
This was referenced Oct 21, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 of the API side of the #1112 drift remediation. Refs #1112. Stacked on API 1 (#1117,
cursor/openapi-drift-remediation-1112-c05d), whose description holds the full plan, the decisions and the follow-up issues.ClickPipeBigQueryPipeSettingsandClickPipeBigQueryPipeSettingsResponsegainsync_cron(syncCron), a cron schedule for CDC syncs that replacessyncIntervalSeconds. It's carried through theTryFromwrite-back.build_bigquery_requestsendssync_cron: None; the existingbuilds_bigquery_cdc_settings_and_method_specific_mappingstest pins the exactsettingsJSON, so the wire request is unchanged.CRON_TZ=schedule, and null tolerance. Library README.spec_coverage_testand the two snapshot-dependent analyzer entrypoint tests fail on this PR by design; they list only the ClickStack findings that API 3 fixes. Everything else passes: the library and analyzer tests (--no-fail-fast),cargo test -p clickhousectl, both clippy configurations, library clippy, andcargo check --workspace --all-features. The BigQuery E2E suite is manual (it needs a third-party GCP project), so I didn't add a live step.