Repository navigation
ci: use single source of truth for supported ClickHouse versions, auto update list - #355
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updater neither refreshes an existing bot PR nor triggers CI for its token-authored PR.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Centralizes supported ClickHouse versions and automates their weekly refresh.
Changes:
- Adds an embedded, generated version catalog.
- Reuses catalog versions across tests and CI matrices.
- Adds a weekly workflow for update pull requests.
| File | Description |
|---|---|
tools/update-clickhouse-versions/main.go |
Generates supported version pins. |
test/supported/versions.json |
Stores pinned versions. |
test/supported/supported.go |
Parses and exposes version data. |
test/testutil/utils.go |
Sources shared test versions. |
test/testutil/fixtures.go |
Uses parsed base versions. |
test/e2e/e2e_suite_test.go |
Reuses the shared catalog. |
test/deploy/deploy_test.go |
Uses pinned deployment versions. |
internal/upgrade/fetcher.go |
Exposes release preprocessing. |
internal/controller/clickhouse/commands_test.go |
Removes a literal image version. |
.github/workflows/ci.yaml |
Generates compatibility matrices from the catalog. |
.github/workflows/update-clickhouse-versions.yaml |
Adds weekly update automation. |
AGENTS.md |
Documents the version source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
GrigoryPervakov
requested review from
mu-soliman
and
a balanced review from Copilot
October 1, 2026 13:52
GrigoryPervakov
force-pushed
the
supported-versions
branch
from
October 1, 2026 13:54
0d18e07 to
05c26f6
Compare
GrigoryPervakov
marked this pull request as ready for review
October 1, 2026 13:54
mu-soliman
approved these changes
Oct 7, 2026
maxknv
added a commit
that referenced
this pull request
Oct 7, 2026
Main #355 moved the compat-e2e matrix to read test/supported/versions.json (single source of truth, auto-updated). Reproduce that in the praktika compat matrix: _clickhouse_versions() computes latest + supported (highest patch per major.minor, descending) from that file, matching ci.yaml jq, instead of hardcoding versions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tested ClickHouse versions are usually stale.
We had 3 places to update.
What