Skip to content

feat: implement Connection::get_info() (#9) - #69

Open
ylw510 wants to merge 7 commits into
ClickHouse:mainfrom
ylw510:feat/get-info
Open

ylw510 wants to merge 7 commits into
ClickHouse:mainfrom
ylw510:feat/get-info

Conversation

@ylw510

@ylw510 ylw510 commented Aug 7, 2026 •

Copy link
Copy Markdown

Summary

  • Implement Connection::get_info() for ADBC driver/vendor metadata (closes Implement Connection::get_info() #9).
  • Return VendorVersion via SELECT version(), plus driver name/version/Arrow/ADBC info; omit unsupported Substrait / vendor Arrow version codes.
  • Resolve DriverArrowVersion at build time with cargo_metadata (from the resolved arrow-array package) instead of a hardcoded string.

Note

Low Risk
Read-only metadata path with a single version query; no auth or data-path changes beyond existing connection I/O.

Overview
Implements Connection::get_info(), replacing the previous NotImplemented stub so clients can read standardized driver and vendor metadata in the ADBC GET_INFO_SCHEMA format.

A new info::InfoBuilder assembles dense-union Arrow batches (string, bool, and int64 values). ClickhouseConnection::build_info fills supported codes when requested (or all when codes is None): vendor name, live VendorVersion from SELECT version(), SQL/Substrait capability flags, and driver name, crate version, and ADBC 1.1.0 version. Vendor Arrow version, Substrait version bounds, and DriverArrowVersion are intentionally omitted where ClickHouse cannot provide them or Arrow cannot represent null union rows.

Integration tests cover full and filtered info requests; changelog and README note the new capability. .cargo/ is added to .gitignore.

Reviewed by Cursor Bugbot for commit 23c89a1. Bugbot is set up for automated code reviews on this repo. Configure here.

ylw510 and others added 2 commits August 7, 2026 02:50
Expose driver/vendor metadata (including server version via SELECT version())
so ADBC clients can discover ClickHouse capabilities.

Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid hardcoding the Arrow crate version; emit it from build.rs using
cargo metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
ylw510 added 2 commits August 7, 2026 16:02
ClickHouse Arrow output no longer includes PARQUET:logical_type on UUID
columns, which broke binary_strings_round_trip under assert_eq!.
Comment thread build.rs Resolved
Drop the build.rs/cargo_metadata approach so we avoid a Cargo-only build
script; restore when arrow-* is bumped far enough for apache/arrow-rs#10957.
@ylw510

ylw510 commented Sep 5, 2026

Copy link
Copy Markdown
Author

@abonander Updated the PR. Please reviewed it again. Thanks.

@ylw510
ylw510 requested a review from abonander September 8, 2026 16:06
@github-actions

Copy link
Copy Markdown

AI review gate — Human approval in place of AI review

Approved on the head commit by abonander (write access, not the author), standing in for the AI review:

  • Cursor Bugbot is still reviewing this commit.

What to do:

  • Nothing to do yet if the review is running. The gate turns green when it finishes clean.
  • No review showing up? Post bugbot run as a new top-level PR comment. If that does nothing, Bugbot is probably not enabled for this repository: ask a repository administrator.

Evaluated at 23c89a14. This required workflow does not re-run on its own once the AI review later concludes — check the Cursor Bugbot check on this commit directly for its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Connection::get_info()

2 participants