Repository navigation
Conversation
Expose driver/vendor metadata (including server version via SELECT version()) so ADBC clients can discover ClickHouse capabilities. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid hardcoding the Arrow crate version; emit it from build.rs using cargo metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
ClickHouse Arrow output no longer includes PARQUET:logical_type on UUID columns, which broke binary_strings_round_trip under assert_eq!.
abonander
requested changes
Aug 31, 2026
Drop the build.rs/cargo_metadata approach so we avoid a Cargo-only build script; restore when arrow-* is bumped far enough for apache/arrow-rs#10957.
Author
|
@abonander Updated the PR. Please reviewed it again. Thanks. |
abonander
approved these changes
Nov 13, 2026
AI review gate — Human approval in place of AI reviewApproved on the head commit by abonander (write access, not the author), standing in for the AI review:
What to do:
Evaluated at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection::get_info()for ADBC driver/vendor metadata (closes ImplementConnection::get_info()#9).VendorVersionviaSELECT version(), plus driver name/version/Arrow/ADBC info; omit unsupported Substrait / vendor Arrow version codes.DriverArrowVersionat build time withcargo_metadata(from the resolvedarrow-arraypackage) instead of a hardcoded string.Note
Low Risk
Read-only metadata path with a single version query; no auth or data-path changes beyond existing connection I/O.
Overview
Implements
Connection::get_info(), replacing the previousNotImplementedstub so clients can read standardized driver and vendor metadata in the ADBCGET_INFO_SCHEMAformat.A new
info::InfoBuilderassembles dense-union Arrow batches (string, bool, and int64 values).ClickhouseConnection::build_infofills supported codes when requested (or all whencodesisNone): vendor name, liveVendorVersionfromSELECT version(), SQL/Substrait capability flags, and driver name, crate version, and ADBC 1.1.0 version. Vendor Arrow version, Substrait version bounds, andDriverArrowVersionare intentionally omitted where ClickHouse cannot provide them or Arrow cannot represent null union rows.Integration tests cover full and filtered info requests; changelog and README note the new capability.
.cargo/is added to.gitignore.Reviewed by Cursor Bugbot for commit 23c89a1. Bugbot is set up for automated code reviews on this repo. Configure here.