Skip to content

Backport #120764 to 26.9: Do not throw from ReplxxLineReader destructor when the terminal is gone - #121408

Merged
clickhouse-gh[bot] merged 2 commits into
26.9from
backport/26.9/120764
Sep 22, 2026
Merged

clickhouse-gh[bot] merged 2 commits into
26.9from
backport/26.9/120764

Conversation

@robot-ch-test-poll3

@robot-ch-test-poll3 robot-ch-test-poll3 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Original pull-request #120764

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

The PR source

The PR is created in the CI job

Version info

  • Merged into: 26.9.2.7

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix labels Sep 21, 2026
@clickhouse-gh

clickhouse-gh Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Workflow [BackportPR], commit [718b053]

Summary: ✅

@alexey-milovidov

Copy link
Copy Markdown
Member

🕵 The only red check, Integration tests (amd_tsan, 2/6) failing test_storage_nats/test_nats_jetstream_credentials_rotation.py::test_jetstream_unacked_messages_survive_rotation with Cannot connect to Nats ... poll error: 4 (EINTR), is unrelated to this backport: it is a fleet-wide flake that also fails on the bare 26.9 and master branches (see the CIDB link in the CI comment). The fix is #120202 (merged to master on 2026-09-21), and its backport to 26.9 is in progress: #121430. The backport diff here is hunk-for-hunk identical to the original #120764 and the branch is up to date with 26.9, so nothing else is needed.

@alexey-milovidov

Copy link
Copy Markdown
Member

🕵 The NATS EINTR fix backport #121430 has merged into 26.9, so I merged 26.9 into this branch (718b053) to pull it in and clear the only red check. The backport diff itself is unchanged.

@clickhouse-gh
clickhouse-gh Bot merged commit 6b4871c into 26.9 Sep 22, 2026
41 checks passed
@clickhouse-gh
clickhouse-gh Bot deleted the backport/26.9/120764 branch September 22, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants