Skip to content

Conversation

@dxu429
Copy link
Contributor

@dxu429 dxu429 commented Jan 22, 2026

Clever Coding Standards Agreement

Jira: https://clever.atlassian.net/browse/DD-7107

Overview:

Bumping to a version of focus trap that supports react 16 and 17.

Screenshots/GIFs:

Screen.Recording.2026-01-21.at.4.53.49.PM.mov

Testing:

(how did you test this)

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

@dxu429 dxu429 marked this pull request as ready for review January 22, 2026 18:06
@dxu429 dxu429 requested review from a team, arielzhu1, mcostag1 and sophlanz and removed request for a team, mcostag1 and sophlanz January 22, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants