Fix updating genres on id3v4 - #90
Open
liviopersonne wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed
/lib/src/writers/id3v4_writer.dartChanges
/as a separator. However, this separator wasn't recognised in musicbee (music management app), but;was correctly recognised and already detected in the parser, so I changed the separator to that. I believe the best option would be|which is also detected in Elisa (music player app) and is the default separator value that is written when modifying the tag manually in musicbee. I haven't been able to correctly write|though because it is automatically escaped during the writing procedure, so I believe other functions would need to be modified, which I don't plan on doing.Fixes
fixes #89