[Glomberg]

https://app.doboard.com/1/task/60124

[codecov]

Codecov Report

❌ Patch coverage is 37.25490% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.54%. Comparing base (c85acbb) to head (b385044).

Files with missing lines	Patch %	Lines
cleantalk.php	0.00%	22 Missing ⚠️
lib/Cleantalk/ApbctWP/Firewall/SFW.php	65.51%	10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (37.25%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev     #917      +/-   ##
============================================
- Coverage     34.54%   34.54%   -0.01%     
- Complexity     7066     7071       +5     
============================================
  Files           298      298              
  Lines         27427    27468      +41     
============================================
+ Hits           9476     9488      +12     
- Misses        17951    17980      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟢 Approval recommended

Production cookie generation and validation use the new format consistently, with no blocking issues identified.

No open issues 🎉

What changed in this PR

This PR hardens SpamFireWall pass cookies by including the pass/whitelist status in the hash and using a consistent format across cookie creation and validation.

Changes:

• Adds shared helpers to generate and strictly validate status-signed pass cookies.
• Updates firewall and AC/AF cookie issuance to use the shared generator.
• Updates related test code; test files were excluded from review.

File	Description
tests/​ApbctWP/​Firewall/​TestSFW.php	Updates pass-cookie tests; excluded from review.
lib/​Cleantalk/​ApbctWP/​Firewall/​SFW.php	Adds status-signed cookie helpers and integrates validation and issuance.
cleantalk.php	Uses the shared generator for AC/AF pass cookies.

_{Review effort: Balanced}