Repository navigation
Upd. Code. Editing the definition of an authorized user - #915
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #915 +/- ##
============================================
+ Coverage 34.54% 34.73% +0.18%
- Complexity 7071 7085 +14
============================================
Files 298 298
Lines 27468 27500 +32
============================================
+ Hits 9488 9551 +63
+ Misses 17980 17949 -31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Security-sensitive lifecycle and token-binding changes need human validation, including resolution of the IPv6 visitor-ID mismatch.
1 open issue
What changed in this PR
This PR strengthens how the plugin recognizes authenticated users and validates successful iframe-protection challenges.
Changes:
- Replaces login-cookie presence checks with WordPress authentication validation.
- Defers AJAX authentication checks and synchronizes contact encoding with user-state changes.
- Adds signed, expiring challenge tokens bound to the site and visitor.
| File | Description |
|---|---|
| tests/StandaloneFunctions/AuthenticationTest.php | Adds authentication tests; excluded from review per repository guidance. |
| tests/ApbctWP/Antispam/ForceProtectionTest.php | Adds protection-token tests; excluded from review per repository guidance. |
| lib/Cleantalk/ApbctWP/ContactsEncoder/ContactsEncoder.php | Synchronizes encoder state when the current user changes. |
| lib/Cleantalk/ApbctWP/Antispam/ForceProtection.php | Generates and validates signed challenge tokens. |
| inc/cleantalk-pluggable.php | Checks verified WordPress authentication. |
| cleantalk.php | Defers AJAX authentication checks until plugins load. |
Review effort: Balanced
svedge
approved these changes
Oct 22, 2026
Glomberg
reviewed
Oct 23, 2026
Glomberg
requested changes
Oct 27, 2026
Glomberg
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/60118