Repository navigation
Validate new spot description length - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unsafe HTML parsing and submission-lock handling introduce script-execution and duplicate-submission risks.
2 open issues
What changed in this PR
Adds a 10-character minimum description length to the widget’s new-spot flow.
Changes:
- Validates description text before submission and during editing.
- Adds length guidance and invalid-button styling.
- Updates the distributed bundle.
| File | Description |
|---|---|
| styles/doboard-widget.css | Styles the invalid submit button. |
| js/src/widget.js | Adds validation and submit-state updates. |
| js/src/loaders/SpotFixTemplatesLoader.js | Adds description-length guidance. |
| js/src/iframe/DescriptionEditorIframe.js | Adds guidance and undo/redo notifications. |
| js/src/constants.js | Defines the minimum description length. |
| dist/doboard-widget-bundle.js | Includes the source and style changes. |
Review effort: Balanced
Comment on lines
+116
to
+117
| } catch (commentErr) { | ||
| console.error(commentErr); |
Glomberg
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/59830