Repository navigation
fix: APK update variant selection & Dolby Atmos stereo lossless fallback - #339
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
universal.apk,universal-uncompressed.apk, orandroid7.apk) instead of always pulling the legacy Android 7 APK.Root Cause & Changes
1. APK Variant Selection
AppUpdateManager.kt, the release asset loop naively grabbed the first asset ending in.apk. Because GitHub releases list assets alphabetically,LastWave-v*-android7.apkwas at index 0, so all users on Android 10+ standard and uncompressed releases were erroneously downloading the legacy Android 7.0 build.classifyAssetandselectBestAssetto properly matchrawRelease(uncompressed), Android 7-9 (legacy), and Android 10+ (universal).2. Dolby Atmos -> Stereo Lossless Fallback
QUALITY_DOLBY_ATMOS= 28) was selected, if the track did not have a spatial audio mix on the addon,LosslessMusicApi.resolveStreamreturnednulland triggerednoteBackendFailure().isCoolingDown) turned on, forcing the current track and all subsequent tracks directly to YouTube Music Opus.LosslessMusicApi.ktandMusicPlayer.kt, when Dolby Atmos is not found, it seamlessly falls back toQUALITY_MAX_HI_RES(Stereo Hi-Res / CD FLAC) without triggering backend failure cooldown.