TUI: triage menu still advertises the refine keys it no longer answers - #110
Merged
Conversation
Removing the menu's `r`/`R` handler left the dim line beneath its action list still offering them, so the menu advertised two keys that now do nothing there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QUiy1Y4sr5kXmKrYqjaTU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dim line beneath the triage menu's action list that still
offered
r refine with a note · R refine by talking. #325 moved those keys tothe queue and removed the menu's handler, but not its advertisement, so the
menu was offering two keys that did nothing there.
No test covered that line, which is why #325 stayed green through the
regression. None is added back — a test asserting the string is absent would
pin behaviour that was never a requirement.
cargo test --workspace279 + 273 passed / 0 failed;cargo clippy --workspace --all-targets -- -D warningsclean.