Prevent packets from having dangerously sized collections (Electric Boogaloo)#125
Draft
Protonull wants to merge 5 commits intoCivPlatform:mainfrom
Draft
Prevent packets from having dangerously sized collections (Electric Boogaloo)#125Protonull wants to merge 5 commits intoCivPlatform:mainfrom
Protonull wants to merge 5 commits intoCivPlatform:mainfrom
Conversation
Copied near-verbatim from CivPlatform#110
These had a weird mixture of interface and namespace. They've now just been replaced with classes and each consolidated into one file.
Protonull
force-pushed
the
fix-oversized-packet-crash
branch
from
f266dd7 to
7c1505d
Compare
Turns out that doing an aggregate function like MAX without having a group by, in this case, is a *bad* idea. Also I seemed to have forgotten that regions are 32x32, not 16x16 :s
Protonull
force-pushed
the
fix-oversized-packet-crash
branch
from
7c1505d to
37be1cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will implement #121