feat: adding dark mode functionality to blog#101
Open
AsherThomasBabu wants to merge 7 commits intoCircuitVerse:masterfrom
Open
feat: adding dark mode functionality to blog#101AsherThomasBabu wants to merge 7 commits intoCircuitVerse:masterfrom
AsherThomasBabu wants to merge 7 commits intoCircuitVerse:masterfrom
Conversation
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Member
|
Any update on upstreaming the changes ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to add dark mode functionality to the blog and closes #56 on merge
In order to override the third party theme, I had to bring the index.html and header.html files to the local repo. I'm not sure if this is a right practice, but seems like the only way.
I also had to remove the SVG background on the hero of the blog, this could either be added in as CSS or left out as such.
The Illustration on the hero also seems a little shabby, If a higher quality image can be linked, that too can be added.
Looking for further input on what else can be improved.
This is a snip of how the current dark mode looks like.
